Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 159900: Use the theme ID as as the cache-buster, making subsequent NNTP loads much fa... (Closed)

Created:
11 years, 4 months ago by Glen Murphy
Modified:
9 years, 5 months ago
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Use the theme ID as as the cache-buster, making subsequent NNTP loads much faster. BUG=18427 TEST=Install a few themes, verify that the NNTP never gets out of sync with the installed theme. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22462

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/dom_ui/dom_ui_theme_source.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Glen Murphy
11 years, 4 months ago (2009-08-05 01:52:28 UTC) #1
arv (Not doing code reviews)
The crash in the try server looks valid. Can you take a look at it?
11 years, 4 months ago (2009-08-05 02:11:13 UTC) #2
Glen Murphy
Updated with less sucking; all that castery was bad for the vibes. On Tue, Aug ...
11 years, 4 months ago (2009-08-05 02:27:26 UTC) #3
arv (Not doing code reviews)
11 years, 4 months ago (2009-08-05 02:47:59 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698