Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 159893007: Revert of Update of change event for datetime input type (Closed)

Created:
6 years, 10 months ago by tkent
Modified:
6 years, 10 months ago
Reviewers:
keishi, Habib Virji
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert of Update of change event for datetime input type (https://codereview.chromium.org/128153002/) Reason for revert: INPUT element dispatches extra events. Original issue's description: > Update of change event for datetime input type > > BaseMultipleFieldDateAndTime includes changes for sending change event when popup is closed, keyboard event and mouse event. > > BaseChoosedOnlyDateAndTime includes changes for sending change event when popup is closed. Special case for input type datetime-local. > > R=tkent > BUG=155747 > TEST=Fixes currently broken test in bug331189 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165455 TBR=keishi@chromium.org,habib.virji@samsung.com NOTREECHECKS=true NOTRY=true BUG=155747 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166970

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -51 lines) Patch
M LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-spinbutton-change-and-input-events-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-spinbutton-change-and-input-events-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-spinbutton-change-and-input-events-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/forms/number/number-spinbutton-change-and-input-events-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/forms/resources/common-spinbutton-change-and-input-events.js View 1 chunk +1 line, -5 lines 0 comments Download
M LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-change-and-input-events-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-spinbutton-change-and-input-events-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp View 3 chunks +1 line, -6 lines 0 comments Download
M Source/core/html/shadow/DateTimeEditElement.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/html/shadow/DateTimeEditElement.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/html/shadow/DateTimeFieldElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/shadow/DateTimeFieldElement.cpp View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tkent
Created Revert of Update of change event for datetime input type
6 years, 10 months ago (2014-02-12 07:35:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/159893007/1
6 years, 10 months ago (2014-02-12 07:35:49 UTC) #2
commit-bot: I haz the power
6 years, 10 months ago (2014-02-12 07:36:20 UTC) #3
Message was sent while issue was closed. 
Change committed as 166970

Powered by Google App Engine
This is Rietveld 408576698