Issue 159891: Make the DOMUIThemeSource load and pass through a PNG, rather than relying on...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159891: Make the DOMUIThemeSource load and pass through a PNG, rather than relying on... (Closed)

Created:
11 years, 4 months ago by Glen Murphy

Modified:
9 years, 5 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Make the DOMUIThemeSource load and pass through a PNG, rather than relying on decode/encode. BUG=18427 TEST=Install a giant theme, load the NNTP, verify that you can type in the omnibox without delay while the page is loading. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22457

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -24 lines)			Patch
M	app/theme_provider.h	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_theme_provider.h	View	1 2	4 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/browser_theme_provider.cc	View	1 2	3 chunks	+18 lines, -0 lines	0 comments	Download
M	chrome/browser/dom_ui/dom_ui_theme_source.cc	View		1 chunk	+6 lines, -10 lines	0 comments	Download
M	chrome/browser/dom_ui/dom_ui_theme_source_unittest.cc	View	4	2 chunks	+6 lines, -10 lines	0 comments	Download
MM	views/widget/default_theme_provider.h	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages