chrome/browser/renderer_host/browser_render_process_host.cc - Issue 159887: Ensure that we never call into WebCore::Page static methods when Page constru...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/browser_render_process_host.cc

Issue 159887: Ensure that we never call into WebCore::Page static methods when Page constru... (Closed) Base URL: svn://chrome-svn.corp.google.com/chrome/trunk/src/

Patch Set: now with comments. Created 11 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_host/browser_render_process_host.h ('k') | chrome/browser/renderer_host/mock_render_process_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/browser_render_process_host.cc

===================================================================

--- chrome/browser/renderer_host/browser_render_process_host.cc (revision 22379)

+++ chrome/browser/renderer_host/browser_render_process_host.cc (working copy)

@@ -196,6 +196,7 @@

: RenderProcessHost(profile),

visible_widgets_(0),

backgrounded_(true),

+ view_created_(false),

ALLOW_THIS_IN_INITIALIZER_LIST(cached_dibs_cleaner_(

base::TimeDelta::FromSeconds(5),

this, &BrowserRenderProcessHost::ClearTransportDIBCache)),

@@ -522,11 +523,17 @@

BadMessageTerminateProcess(msg_type, process_.handle());

}

+void BrowserRenderProcessHost::ViewCreated() {

+ view_created_ = true;

+ visited_link_updater_->Update(this);

void BrowserRenderProcessHost::WidgetRestored() {

// Verify we were properly backgrounded.

DCHECK_EQ(backgrounded_, (visible_widgets_ == 0));

visible_widgets_++;

- visited_link_updater_->Update(this);

+ if (view_created_)

+ visited_link_updater_->Update(this);

SetBackgrounded(false);

}