chrome/browser/ui/webui/options/language_options_handler_common.cc - Issue 159883002: Move TranslatePrefs to the Translate component

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/language_options_handler_common.cc

Issue 159883002: Move TranslatePrefs to the Translate component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@acceptLanguages

Patch Set: Fix ChromeOS browsertests Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/infobars/translate_infobar_unittest.mm ('k') | chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc » ('j') | components/translate.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/language_options_handler_common.cc

diff --git a/chrome/browser/ui/webui/options/language_options_handler_common.cc b/chrome/browser/ui/webui/options/language_options_handler_common.cc

index 4059e1e565a5257ba84fbf9c101289b9cdddeb8b..c5fb995b167703d3122f74b4a3523ab03253d06b 100644

--- a/chrome/browser/ui/webui/options/language_options_handler_common.cc

+++ b/chrome/browser/ui/webui/options/language_options_handler_common.cc

@@ -22,12 +22,13 @@

#include "chrome/browser/spellchecker/spellcheck_factory.h"

#include "chrome/browser/spellchecker/spellcheck_service.h"

#include "chrome/browser/translate/translate_manager.h"

-#include "chrome/browser/translate/translate_prefs.h"

+#include "chrome/browser/translate/translate_tab_helper.h"

#include "chrome/browser/ui/browser_list.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/pref_names.h"

#include "chrome/common/spellcheck_common.h"

#include "components/translate/core/browser/translate_download_manager.h"

+#include "components/translate/core/browser/translate_prefs.h"

#include "content/public/browser/user_metrics.h"

#include "content/public/browser/web_ui.h"

#include "grit/chromium_strings.h"

@@ -263,9 +264,9 @@ void LanguageOptionsHandlerCommon::UpdateLanguageListCallback(

}

Profile* profile = Profile::FromWebUI(web_ui());

- PrefService* prefs = profile->GetPrefs();

- TranslatePrefs translate_prefs(prefs);

- translate_prefs.UpdateLanguageList(languages);

+ scoped_ptr<TranslatePrefs> translate_prefs =

+ TranslateTabHelper::CreateTranslatePrefs(profile->GetPrefs());

+ translate_prefs->UpdateLanguageList(languages);

}

void LanguageOptionsHandlerCommon::RetrySpellcheckDictionaryDownload(