chrome/browser/storage_monitor/storage_monitor_mac.mm - Issue 15988011: Refine StorageMonitor storage device getter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/storage_monitor/storage_monitor_mac.mm

Issue 15988011: Refine StorageMonitor storage device getter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/storage_monitor/storage_monitor_mac.mm

diff --git a/chrome/browser/storage_monitor/storage_monitor_mac.mm b/chrome/browser/storage_monitor/storage_monitor_mac.mm

index 266f6114a0199a4ceb97fd0cab34d4fdeec7cb7b..010bf9d2fec96224a0f12ec8ee74a74ba6b78a08 100644

--- a/chrome/browser/storage_monitor/storage_monitor_mac.mm

+++ b/chrome/browser/storage_monitor/storage_monitor_mac.mm

@@ -353,7 +353,6 @@ bool StorageMonitorMac::ShouldPostNotificationForDisk(

return !info.device_id().empty() &&

!info.location().empty() &&

info.model_name() != ASCIIToUTF16(kDiskImageModelName) &&

- StorageInfo::IsRemovableDevice(info.device_id()) &&

Hongbo Min 2013/06/04 02:52:29 Why to remove it?

StorageInfo::IsMassStorageDevice(info.device_id());

}