chrome/browser/storage_monitor/storage_monitor_win_unittest.cc - Issue 15988011: Refine StorageMonitor storage device getter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/storage_monitor/storage_monitor_win_unittest.cc

Issue 15988011: Refine StorageMonitor storage device getter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix SystemInfoStorageApiTest failures in browser_tests Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/storage_monitor/storage_monitor_win_unittest.cc

diff --git a/chrome/browser/storage_monitor/storage_monitor_win_unittest.cc b/chrome/browser/storage_monitor/storage_monitor_win_unittest.cc

index be88a2e7b1b03625afca3c2604f50080b6850e12..8c1ec60869df698486e026d8666c16cecedaeb8f 100644

--- a/chrome/browser/storage_monitor/storage_monitor_win_unittest.cc

+++ b/chrome/browser/storage_monitor/storage_monitor_win_unittest.cc

@@ -291,7 +291,7 @@ TEST_F(StorageMonitorWinTest, DevicesAttached) {

TEST_F(StorageMonitorWinTest, PathMountDevices) {

PreAttachDevices();

- int init_storages = monitor_->GetAttachedStorage().size();

+ int init_storages = monitor_->GetAllAvailableStorages().size();

volume_mount_watcher_->AddDeviceForTesting(

base::FilePath(FILE_PATH_LITERAL("F:\\mount1")),

@@ -303,7 +303,7 @@ TEST_F(StorageMonitorWinTest, PathMountDevices) {

base::FilePath(FILE_PATH_LITERAL("F:\\mount2")),

"dcim:mount2", L"mount2", 100);

RunUntilIdle();

- EXPECT_EQ(init_storages + 3, monitor_->GetAttachedStorage().size());

+ EXPECT_EQ(init_storages + 3, monitor_->GetAllAvailableStorages().size());

StorageInfo info;

EXPECT_TRUE(monitor_->GetStorageInfoForPath(