Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2420)

Unified Diff: chrome/browser/translate/translate_manager_browsertest.cc

Issue 15987004: Translate: Filter and record languages whose names Chrome doesn't show (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Modified the test Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/translate/translate_manager.cc ('k') | chrome/browser/translate/translate_manager_metrics.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/translate/translate_manager_browsertest.cc
diff --git a/chrome/browser/translate/translate_manager_browsertest.cc b/chrome/browser/translate/translate_manager_browsertest.cc
index cf7dd73302f926b994d9fda75c34c434442f99a0..2cc798b8d8a3dd81b9c9746972fff1a3f8da7fab 100644
--- a/chrome/browser/translate/translate_manager_browsertest.cc
+++ b/chrome/browser/translate/translate_manager_browsertest.cc
@@ -624,12 +624,13 @@ TEST_F(TranslateManagerBrowserTest, FetchLanguagesFromTranslateServer) {
std::vector<std::string> server_languages;
// A list of languages to fake being returned by the translate server.
server_languages.push_back("aa");
- server_languages.push_back("bb");
+ server_languages.push_back("ak");
server_languages.push_back("ab");
server_languages.push_back("en-CA");
- server_languages.push_back("zz");
- server_languages.push_back("yy");
+ server_languages.push_back("zh");
+ server_languages.push_back("yi");
server_languages.push_back("fr-FR");
+ server_languages.push_back("xx");
// First, get the default languages list:
std::vector<std::string> default_supported_languages;
@@ -658,9 +659,12 @@ TEST_F(TranslateManagerBrowserTest, FetchLanguagesFromTranslateServer) {
SimulateSupportedLanguagesURLFetch(true, server_languages);
current_supported_languages.clear();
TranslateManager::GetSupportedLanguages(&current_supported_languages);
+ // "xx" can't be displayed in the Translate inforbar, so this is eliminated.
+ EXPECT_EQ(server_languages.size() - 1, current_supported_languages.size());
// Not sure we need to guarantee the order of languages, so we find them.
- EXPECT_EQ(server_languages.size(), current_supported_languages.size());
for (size_t i = 0; i < server_languages.size(); ++i) {
+ if (server_languages[i] == "xx")
+ continue;
EXPECT_NE(current_supported_languages.end(),
std::find(current_supported_languages.begin(),
current_supported_languages.end(),
« no previous file with comments | « chrome/browser/translate/translate_manager.cc ('k') | chrome/browser/translate/translate_manager_metrics.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698