Translate: Filter and record languages whose names Chrome doesn't show

chrome/browser/translate/translate_manager.cc

Index: chrome/browser/translate/translate_manager.cc
diff --git a/chrome/browser/translate/translate_manager.cc b/chrome/browser/translate/translate_manager.cc
index 01c9451163dbc7ffd04df97ce32570d184a0a978..de6d1bcd1bd607abdb433416f74df90e84b0a9c6 100644
--- a/chrome/browser/translate/translate_manager.cc
+++ b/chrome/browser/translate/translate_manager.cc
@@ -22,10 +22,10 @@
 #include "chrome/browser/tab_contents/language_state.h"
 #include "chrome/browser/tab_contents/tab_util.h"
 #include "chrome/browser/translate/page_translated_details.h"
+#include "chrome/browser/translate/translate_browser_metrics.h"
 #include "chrome/browser/translate/translate_error_details.h"
 #include "chrome/browser/translate/translate_infobar_delegate.h"
 #include "chrome/browser/translate/translate_language_list.h"
-#include "chrome/browser/translate/translate_manager_metrics.h"
 #include "chrome/browser/translate/translate_prefs.h"
 #include "chrome/browser/translate/translate_tab_helper.h"
 #include "chrome/browser/translate/translate_url_util.h"
@@ -390,8 +390,8 @@ void TranslateManager::InitiateTranslation(WebContents* web_contents,
       Profile::FromBrowserContext(web_contents->GetBrowserContext());
   PrefService* prefs = profile->GetOriginalProfile()->GetPrefs();
   if (!prefs->GetBoolean(prefs::kEnableTranslate)) {
-    TranslateManagerMetrics::ReportInitiationStatus(
-        TranslateManagerMetrics::INITIATION_STATUS_DISABLED_BY_PREFS);
+    TranslateBrowserMetrics::ReportInitiationStatus(
+        TranslateBrowserMetrics::INITIATION_STATUS_DISABLED_BY_PREFS);
     return;
   }
 
@@ -399,8 +399,8 @@ void TranslateManager::InitiateTranslation(WebContents* web_contents,
   // automated browser testing.
   if (CommandLine::ForCurrentProcess()->HasSwitch(
       switches::kDisableTranslate)) {
-    TranslateManagerMetrics::ReportInitiationStatus(
-        TranslateManagerMetrics::INITIATION_STATUS_DISABLED_BY_SWITCH);
+    TranslateBrowserMetrics::ReportInitiationStatus(
+        TranslateBrowserMetrics::INITIATION_STATUS_DISABLED_BY_SWITCH);
     return;
   }
 
@@ -408,8 +408,8 @@ void TranslateManager::InitiateTranslation(WebContents* web_contents,
   // History, and so on.
   GURL page_url = web_contents->GetURL();
   if (!IsTranslatableURL(page_url)) {
-    TranslateManagerMetrics::ReportInitiationStatus(
-        TranslateManagerMetrics::INITIATION_STATUS_URL_IS_NOT_SUPPORTED);
+    TranslateBrowserMetrics::ReportInitiationStatus(
+        TranslateBrowserMetrics::INITIATION_STATUS_URL_IS_NOT_SUPPORTED);
     return;
   }
 
@@ -417,24 +417,24 @@ void TranslateManager::InitiateTranslation(WebContents* web_contents,
   std::string target_lang = GetTargetLanguage(prefs);
   std::string language_code = GetLanguageCode(page_lang);
   if (language_code == target_lang) {
-    TranslateManagerMetrics::ReportInitiationStatus(
-        TranslateManagerMetrics::INITIATION_STATUS_SIMILAR_LANGUAGES);
+    TranslateBrowserMetrics::ReportInitiationStatus(
+        TranslateBrowserMetrics::INITIATION_STATUS_SIMILAR_LANGUAGES);
     return;
   }
 
   // Don't translate any language the user configured as accepted languages.
   if (IsAcceptLanguage(web_contents, language_code)) {
-    TranslateManagerMetrics::ReportInitiationStatus(
-        TranslateManagerMetrics::INITIATION_STATUS_ACCEPT_LANGUAGES);
+    TranslateBrowserMetrics::ReportInitiationStatus(
+        TranslateBrowserMetrics::INITIATION_STATUS_ACCEPT_LANGUAGES);
     return;
   }
 
   // Nothing to do if either the language Chrome is in or the language of the
   // page is not supported by the translation server.
   if (target_lang.empty() || !IsSupportedLanguage(language_code)) {
-    TranslateManagerMetrics::ReportInitiationStatus(
-        TranslateManagerMetrics::INITIATION_STATUS_LANGUAGE_IS_NOT_SUPPORTED);
-    TranslateManagerMetrics::ReportUnsupportedLanguageAtInitiation(
+    TranslateBrowserMetrics::ReportInitiationStatus(
+        TranslateBrowserMetrics::INITIATION_STATUS_LANGUAGE_IS_NOT_SUPPORTED);
+    TranslateBrowserMetrics::ReportUnsupportedLanguageAtInitiation(
         language_code);
 
     return;
@@ -443,8 +443,8 @@ void TranslateManager::InitiateTranslation(WebContents* web_contents,
   // Don't translate any user black-listed URLs or user selected language
   // combination.
   if (!TranslatePrefs::CanTranslate(prefs, language_code, page_url)) {
-    TranslateManagerMetrics::ReportInitiationStatus(
-        TranslateManagerMetrics::INITIATION_STATUS_DISABLED_BY_CONFIG);
+    TranslateBrowserMetrics::ReportInitiationStatus(
+        TranslateBrowserMetrics::INITIATION_STATUS_DISABLED_BY_CONFIG);
     return;
   }
 
@@ -460,8 +460,8 @@ void TranslateManager::InitiateTranslation(WebContents* web_contents,
     // Also, GetLanguageCode will take care of removing country code if any.
     auto_target_lang = GetLanguageCode(auto_target_lang);
     if (IsSupportedLanguage(auto_target_lang)) {
-      TranslateManagerMetrics::ReportInitiationStatus(
-          TranslateManagerMetrics::INITIATION_STATUS_AUTO_BY_CONFIG);
+      TranslateBrowserMetrics::ReportInitiationStatus(
+          TranslateBrowserMetrics::INITIATION_STATUS_AUTO_BY_CONFIG);
       TranslatePage(web_contents, language_code, auto_target_lang);
       return;
     }
@@ -476,15 +476,15 @@ void TranslateManager::InitiateTranslation(WebContents* web_contents,
       translate_tab_helper->language_state().AutoTranslateTo();
   if (!auto_translate_to.empty()) {
     // This page was navigated through a click from a translated page.
-    TranslateManagerMetrics::ReportInitiationStatus(
-        TranslateManagerMetrics::INITIATION_STATUS_AUTO_BY_LINK);
+    TranslateBrowserMetrics::ReportInitiationStatus(
+        TranslateBrowserMetrics::INITIATION_STATUS_AUTO_BY_LINK);
     TranslatePage(web_contents, language_code, auto_translate_to);
     return;
   }
 
   // Prompts the user if he/she wants the page translated.
-  TranslateManagerMetrics::ReportInitiationStatus(
-      TranslateManagerMetrics::INITIATION_STATUS_SHOW_INFOBAR);
+  TranslateBrowserMetrics::ReportInitiationStatus(
+      TranslateBrowserMetrics::INITIATION_STATUS_SHOW_INFOBAR);
   TranslateInfoBarDelegate::Create(
       InfoBarService::FromWebContents(web_contents), false,
       TranslateInfoBarDelegate::BEFORE_TRANSLATE, TranslateErrors::NONE,
@@ -582,7 +582,7 @@ void TranslateManager::RevertTranslation(WebContents* web_contents) {
 }
 
 void TranslateManager::ReportLanguageDetectionError(WebContents* web_contents) {
-  TranslateManagerMetrics::ReportLanguageDetectionError();
+  TranslateBrowserMetrics::ReportLanguageDetectionError();
   // We'll open the URL in a new tab so that the user can tell us more.
   Browser* browser = chrome::FindBrowserWithWebContents(web_contents);
   if (!browser) {
@@ -638,10 +638,6 @@ void TranslateManager::PageTranslated(WebContents* web_contents,
   if ((details->error_type == TranslateErrors::NONE) &&
       details->source_language != chrome::kUnknownLanguageCode &&
       !IsSupportedLanguage(details->source_language)) {
-    // TODO(toyoshim): http://crbug.com/242142 We should check if
-    // l10n_util::GetDisplayNameForLocale() support |source_language| here.
-    // Also, following metrics should be modified to have language code.
-    TranslateManagerMetrics::ReportUnsupportedLanguage();
     details->error_type = TranslateErrors::UNSUPPORTED_LANGUAGE;
   }