Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: chrome/browser/translate/translate_browser_metrics.h

Issue 15987004: Translate: Filter and record languages whose names Chrome doesn't show (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Made Translate.ServerReportedUnsupportedLanguage deprecated Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/translate_browser_metrics.h
diff --git a/chrome/browser/translate/translate_manager_metrics.h b/chrome/browser/translate/translate_browser_metrics.h
similarity index 75%
rename from chrome/browser/translate/translate_manager_metrics.h
rename to chrome/browser/translate/translate_browser_metrics.h
index 98ba3503d142aec9b2999c684f0bc6b90f9fe5f8..63a2a79ad190b13d761591b5c9dd251047663347 100644
--- a/chrome/browser/translate/translate_manager_metrics.h
+++ b/chrome/browser/translate/translate_browser_metrics.h
@@ -2,20 +2,20 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_TRANSLATE_TRANSLATE_MANAGER_METRICS_H_
-#define CHROME_BROWSER_TRANSLATE_TRANSLATE_MANAGER_METRICS_H_
+#ifndef CHROME_BROWSER_TRANSLATE_TRANSLATE_BROWSER_METRICS_H_
+#define CHROME_BROWSER_TRANSLATE_TRANSLATE_BROWSER_METRICS_H_
#include <string>
-namespace TranslateManagerMetrics {
+namespace TranslateBrowserMetrics {
// An indexing type to query each UMA entry name via GetMetricsName() function.
// Note: |kMetricsEntries| should be updated when a new entry is added here.
enum MetricsNameIndex {
UMA_INITIATION_STATUS,
UMA_LANGUAGE_DETECTION_ERROR,
- UMA_SERVER_REPORTED_UNSUPPORTED_LANGUAGE,
UMA_UNSUPPORTED_LANGUAGE_AT_INITIATION,
+ UMA_UNDISPLAYABLE_LANGUAGE,
UMA_MAX,
};
@@ -44,14 +44,15 @@ void ReportInitiationStatus(InitiationStatusType type);
// Called when Chrome opens the URL so that the user sends an error feedback.
void ReportLanguageDetectionError();
-// Called when it turns out that translating page is in unsupported language.
-void ReportUnsupportedLanguage();
-
void ReportUnsupportedLanguageAtInitiation(const std::string& language);
+// Called when Chrome Translate server sends the language list which includes
+// a undisplayable language in the user's locale.
+void ReportUndisplayableLanguage(const std::string& language);
+
// Provides UMA entry names for unit tests.
const char* GetMetricsName(MetricsNameIndex index);
-} // namespace TranslateManagerMetrics
+} // namespace TranslateBrowserMetrics
-#endif // CHROME_BROWSER_TRANSLATE_TRANSLATE_MANAGER_METRICS_H_
+#endif // CHROME_BROWSER_TRANSLATE_TRANSLATE_BROWSER_METRICS_H_

Powered by Google App Engine
This is Rietveld 408576698