chrome/browser/translate/translate_manager_metrics_unittest.cc - Issue 15987004: Translate: Filter and record languages whose names Chrome doesn't show

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/translate/translate_manager_metrics_unittest.cc

Issue 15987004: Translate: Filter and record languages whose names Chrome doesn't show (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/translate/translate_language_list.cc ('K') | « chrome/browser/translate/translate_manager_metrics.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/translate/translate_manager_metrics_unittest.cc

diff --git a/chrome/browser/translate/translate_manager_metrics_unittest.cc b/chrome/browser/translate/translate_manager_metrics_unittest.cc

index 0c174cc5e47d5f530affbe06c6aa0836ec3bddc0..b0058f7d1b4570674411d6cdb0f01237e9863ef2 100644

--- a/chrome/browser/translate/translate_manager_metrics_unittest.cc

+++ b/chrome/browser/translate/translate_manager_metrics_unittest.cc

@@ -169,3 +169,13 @@ TEST(TranslateManagerMetricsTest, ReportedUnsupportedLanguageAtInitiation) {

TranslateManagerMetrics::ReportUnsupportedLanguageAtInitiation("en");

EXPECT_EQ(1, recorder.GetCount(ENGLISH));

}

+TEST(TranslateManagerMetricsTest, ReportedUndisplayableLanguage) {

+ const int ENGLISH = 25966;

+ MetricsRecorder recorder(TranslateManagerMetrics::GetMetricsName(

+ TranslateManagerMetrics::UMA_UNDISPLAYABLE_LANGUAGE));

+ EXPECT_EQ(0, recorder.GetTotalCount());

+ TranslateManagerMetrics::ReportUndisplayableLanguage("en");

+ EXPECT_EQ(1, recorder.GetCount(ENGLISH));