Issue 159864: Keep scrollbars (etc.) active upon pulling down menu extra....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159864: Keep scrollbars (etc.) active upon pulling down menu extra.... (Closed)

Created:
11 years, 4 months ago by viettrungluu-gmail

Modified:
9 years, 7 months ago

Reviewers:
Avi (use Gerrit), pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com, John Grabowski, Ben Goodger (Google)

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Keep scrollbars (etc.) active upon pulling down menu extra. BUG=17990 TEST=Go to a window with scrollbar and pull down menu extra; also check what happens when moving around between different apps and different Chromium windows.

Patch Set 1 #

Total comments: 2

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	chrome/browser/cocoa/browser_window_controller.mm	View		1 chunk	+7 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

On 2009/08/04 19:19:34, Avi wrote: > LG Committed r22421.

11 years, 4 months ago (2009-08-04 21:57:59 UTC) #2

pink (ping after 24hrs)

http://codereview.chromium.org/159864/diff/1/2 File chrome/browser/cocoa/browser_window_controller.mm (right): http://codereview.chromium.org/159864/diff/1/2#newcode330 Line 330: if ([NSApp isActive] && ([NSApp keyWindow] == window_)) ...

11 years, 4 months ago (2009-08-12 14:49:16 UTC) #3

viettrungluu-gmail

11 years, 4 months ago (2009-08-12 14:59:21 UTC) #4

http://codereview.chromium.org/159864/diff/1/2
File chrome/browser/cocoa/browser_window_controller.mm (right):

http://codereview.chromium.org/159864/diff/1/2#newcode330
Line 330: if ([NSApp isActive] && ([NSApp keyWindow] == window_))
What do you mean, "panel"? (AFAICT, it works as it's supposed to, or at least
like every other app.)

Note that this logic (arrived at by experimentation/monitoring) keeps the
scrollbars as expected. Other controls -- such as text boxes -- in web content
now behave a little oddly (I think the standard Cocoa controls, other than
scrollbars, just monitor key window status)....

Expand Messages | Collapse Messages