LayoutTests/fast/regions/no-split-line-box.html - Issue 159863002: Remove CSS regions support, keeping a bare minimum to support "region-based" multicol.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/regions/no-split-line-box.html

Issue 159863002: Remove CSS regions support, keeping a bare minimum to support "region-based" multicol. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/regions/named-flow-content-order-3-expected.html ('k') | LayoutTests/fast/regions/no-split-line-box-expected.txt » ('j') | Source/devtools/front_end/protocol_externs.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 <!--

2 Each of the two regions should only display two line boxes in this test.

3 The buggy behavior splits the third line box between the first and second regi on.

4 -->

5 <script type="text/javascript" charset="utf-8" src="resources/helper.js"></scrip t>

6

7 <style type="text/css">

8 .article{

9 -webkit-flow-into: thread;

10 line-height:14px;

11 }

12 .region{

13 -webkit-flow-from: thread;

14 width:4em;

15 height:35px; /2.5x line height/

16 background-color:lightgray;

17 }

18 .divider{

19 width:4em;

20 height:10px;

21 }

22 .description{

23 color:blue;

24 }

25 </style>

26

27 <div id="test">

28 <div class="region"></div>

29 <div class="divider"></div>

30 <div id="secondRegion" class="region"></div>

31 <div class="article">

32 mnopqr mnopqr <span id="testSpan">m</span>nopqr mnopqr

33 </div>

34 <p class="description">The two regions on either side of the divider should ea ch have two text lines.</p>

35 <p class="description">There should be no text line split between the regions. </p>

36 <p class="description">The top left corner of the third text line should be in the top left corner of the second region.</p>

37 </div>

38 <div id="result"></div>

39

40 <script>

41 if (window.testRunner)

42 testRunner.dumpAsText();

43

44 var testElement = document.getElementById("testSpan")

45 var testRect = testElement.getBoundingClientRect();

46 var regionElement = document.getElementById("secondRegion")

47 var regionRect = regionElement.getBoundingClientRect();

48 var resultString = assertTopLeftMatch (regionRect, testRect);

49

50 if (window.testRunner)

51 document.getElementById("test").innerText="";

52 var resultDiv = document.getElementById("result");

53 resultDiv.innerText = resultString;

54 </script>

OLD	NEW