Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 15986006: Don't create an unbadged shortcut when first profile is created. (Closed)

Created:
7 years, 7 months ago by Alexei Svitkine (slow)
Modified:
7 years, 7 months ago
CC:
chromium-reviews, sail+watch_chromium.org
Visibility:
Public.

Description

Don't create an unbadged shortcut when first profile is created. This fixes all sorts of issues where the first run would create a new shortcut on the desktop, when it may not be desired. This code was originally added to handle the case where you delete your last profile (which would delete its shortcut), and then when a new profile would be created in its place, the desktop would no longer have the shortcut it had originally. However, in the current code deleting the last profile will not delete the regular Chrome shortcut off the desktop (when only one profile is left, the shortcut is not a profile specific shortcut, but a plain shortcut to the exe), since DeleteDesktopShortcutsAndIconFile() only looks for profile shortcuts. Thus the code this is deleting is no longer necessary to handle the case it was originally added for and can be safely removed. Also, updates unit tests appropriately. BUG=232940 TEST=Install Chrome with a master prefs file that says not to create a shortcut and launch it; a shortcut shouldn't be added. (See bug for more details). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202293

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -18 lines) Patch
M chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc View 1 chunk +7 lines, -11 lines 0 comments Download
M chrome/browser/profiles/profile_shortcut_manager_win.cc View 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Alexei Svitkine (slow)
7 years, 7 months ago (2013-05-24 20:08:29 UTC) #1
sail
makes sense I guess, LGTM
7 years, 7 months ago (2013-05-24 20:31:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/15986006/10001
7 years, 7 months ago (2013-05-24 20:33:17 UTC) #3
gab
lgtm, thanks!
7 years, 7 months ago (2013-05-24 22:10:13 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=153794
7 years, 7 months ago (2013-05-25 00:53:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/15986006/10001
7 years, 7 months ago (2013-05-25 02:54:27 UTC) #6
commit-bot: I haz the power
7 years, 7 months ago (2013-05-25 14:41:30 UTC) #7
Message was sent while issue was closed.
Change committed as 202293

Powered by Google App Engine
This is Rietveld 408576698