Issue 15986003: DevTools: [CodeMirror] autocompletion for CodeMirrorTextEditor

Issue 15986003: DevTools: [CodeMirror] autocompletion for CodeMirrorTextEditor (Closed)

Created:
7 years, 7 months ago by lushnikov

Modified:
7 years, 7 months ago

Reviewers:
vsevik

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: [CodeMirror] autocompletion for CodeMirrorTextEditor Add autocompletion functionality for CodeMirrorTextEditor. Autocompletion works by maintaining a synchronized state of completion dictionary so that it contains all the words in the the text document. The dictionary is updated incrementally by listening to the beforeChange and onChange events. BUG=167290 R=vsevik@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151191

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comments #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+159 lines, -3 lines)			Patch
M	Source/devtools/front_end/CodeMirrorTextEditor.js	View	1	8 chunks	+120 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/CompletionDictionary.js	View		2 chunks	+15 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/Settings.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/devtools/front_end/TextUtils.js	View		1 chunk	+18 lines, -1 line	0 comments	Download
M	Source/devtools/front_end/UISourceCodeFrame.js	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/externs.js	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

vsevik

lgtm https://codereview.chromium.org/15986003/diff/1/Source/devtools/front_end/CodeMirrorTextEditor.js File Source/devtools/front_end/CodeMirrorTextEditor.js (right): https://codereview.chromium.org/15986003/diff/1/Source/devtools/front_end/CodeMirrorTextEditor.js#newcode100 Source/devtools/front_end/CodeMirrorTextEditor.js:100: extra line https://codereview.chromium.org/15986003/diff/1/Source/devtools/front_end/JavaScriptSourceFrame.js File Source/devtools/front_end/JavaScriptSourceFrame.js (right): https://codereview.chromium.org/15986003/diff/1/Source/devtools/front_end/JavaScriptSourceFrame.js#newcode51 Source/devtools/front_end/JavaScriptSourceFrame.js:51: ...

7 years, 7 months ago (2013-05-24 16:32:34 UTC) #2

lushnikov

7 years, 7 months ago (2013-05-27 13:29:51 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r151191 (presubmit successful).

Expand Messages | Collapse Messages