Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 159860: Temporarily disable all Worker tests. (Closed)

Created:
11 years, 4 months ago by dglazkov
Modified:
9 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews_googlegroups.com, jam
Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/
Visibility:
Public.

Description

Temporarily disable all Worker tests. TBR=jam BUG=18409 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22385

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/worker/worker_uitest.cc View 6 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dglazkov
11 years, 4 months ago (2009-08-04 17:14:59 UTC) #1
jianli
11 years, 4 months ago (2009-08-04 18:25:58 UTC) #2
Worker tests are broken by http://trac.webkit.org/changeset/46745. I will
figure out what to do about this.

On Tue, Aug 4, 2009 at 10:15 AM, <dglazkov@chromium.org> wrote:

>
> Reviewers: John Abd-El-Malek,
>
> Description:
> Temporarily disable all Worker tests.
>
> TBR=jam
> BUG=18409
> TEST=none
>
>
> Please review this at http://codereview.chromium.org/159860
>
> SVN Base: svn://chrome-svn.corp.google.com/chrome/trunk/src/
>
> Affected files:
>  M     chrome/worker/worker_uitest.cc
>
>
> Index: chrome/worker/worker_uitest.cc
> ===================================================================
> --- chrome/worker/worker_uitest.cc      (revision 22379)
> +++ chrome/worker/worker_uitest.cc      (working copy)
> @@ -288,15 +288,15 @@
>                                      expected_result_value);
>  }
>
> -TEST_F(WorkerTest, SingleWorker) {
> +TEST_F(WorkerTest, DISABLED_SingleWorker) {
>   RunTest(L"single_worker.html");
>  }
>
> -TEST_F(WorkerTest, MultipleWorkers) {
> +TEST_F(WorkerTest, DISABLED_MultipleWorkers) {
>   RunTest(L"multi_worker.html");
>  }
>
> -TEST_F(WorkerTest, WorkerFastLayoutTests) {
> +TEST_F(WorkerTest, DISABLED_WorkerFastLayoutTests) {
>   static const char* kLayoutTestFiles[] = {
>     "stress-js-execution.html",
>     "use-machine-stack.html",
> @@ -327,7 +327,7 @@
>     RunLayoutTest(kLayoutTestFiles[i], false);
>  }
>
> -TEST_F(WorkerTest, WorkerHttpLayoutTests) {
> +TEST_F(WorkerTest, DISABLED_WorkerHttpLayoutTests) {
>   static const char* kLayoutTestFiles[] = {
>     // flakey? BUG 16934 "text-encoding.html",
>     "worker-importScripts.html",
> @@ -349,7 +349,7 @@
>   StopHttpServer();
>  }
>
> -TEST_F(WorkerTest, WorkerXhrHttpLayoutTests) {
> +TEST_F(WorkerTest, DISABLED_WorkerXhrHttpLayoutTests) {
>   static const char* kLayoutTestFiles[] = {
>     "abort-exception-assert.html",
>     "close.html",
> @@ -374,7 +374,7 @@
>   StopHttpServer();
>  }
>
> -TEST_F(WorkerTest, MessagePorts) {
> +TEST_F(WorkerTest, DISABLED_MessagePorts) {
>   static const char* kLayoutTestFiles[] = {
>     "message-channel-gc.html",
>     "message-channel-gc-2.html",
> @@ -403,7 +403,7 @@
>     RunLayoutTest(kLayoutTestFiles[i], false);
>  }
>
> -TEST_F(WorkerTest, LimitPerPage) {
> +TEST_F(WorkerTest, DISABLED_LimitPerPage) {
>   int max_workers_per_tab = WorkerService::kMaxWorkersPerTabWhenSeparate;
>   GURL url = GetTestUrl(L"workers", L"many_workers.html");
>   url = GURL(url.spec() + StringPrintf("?count=%d", max_workers_per_tab +
> 1));
> @@ -416,7 +416,7 @@
>             UITest::GetBrowserProcessCount());
>  }
>
> -TEST_F(WorkerTest, LimitTotal) {
> +TEST_F(WorkerTest, DISABLED_LimitTotal) {
>   int max_workers_per_tab = WorkerService::kMaxWorkersPerTabWhenSeparate;
>   int total_workers = WorkerService::kMaxWorkersWhenSeparate;
>
>
>
>

Powered by Google App Engine
This is Rietveld 408576698