content/browser/accessibility/browser_accessibility_manager_android.cc - Issue 1598583002: Fixed algorithms that compute bounding rectangles and word start offsets to take into account IA2 h…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_manager_android.cc

Issue 1598583002: Fixed algorithms that compute bounding rectangles and word start offsets to take into account IA2 h… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added a TODO to investigate test failure on Linux. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_cocoa.mm ('k') | content/browser/accessibility/browser_accessibility_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_manager_android.cc

diff --git a/content/browser/accessibility/browser_accessibility_manager_android.cc b/content/browser/accessibility/browser_accessibility_manager_android.cc

index 6be36777e2dc06b892bcd5905d2aae101a5f3afc..57dd100c5713f7ad6126bf008f19c72266199715 100644

--- a/content/browser/accessibility/browser_accessibility_manager_android.cc

+++ b/content/browser/accessibility/browser_accessibility_manager_android.cc

@@ -179,7 +179,7 @@ void BrowserAccessibilityManagerAndroid::NotifyAccessibilityEvent(

break;

case ui::AX_EVENT_TEXT_CHANGED:

case ui::AX_EVENT_VALUE_CHANGED:

- if (node->IsEditableText() && GetFocus(GetRoot()) == node) {

+ if (android_node->IsEditableText() && GetFocus(GetRoot()) == node) {

Java_BrowserAccessibilityManager_handleEditableTextChanged(

env, obj.obj(), node->GetId());

} else if (android_node->IsSlider()) {