Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Unified Diff: content/browser/accessibility/browser_accessibility.h

Issue 1598583002: Fixed algorithms that compute bounding rectangles and word start offsets to take into account IA2 h… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added a TODO to investigate test failure on Linux. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility.h
diff --git a/content/browser/accessibility/browser_accessibility.h b/content/browser/accessibility/browser_accessibility.h
index 72f5cd5c041e5d8f288c809c2500ca627deabc2e..9b1a3feb41117a709397baed6ecd2ae04411c406 100644
--- a/content/browser/accessibility/browser_accessibility.h
+++ b/content/browser/accessibility/browser_accessibility.h
@@ -287,6 +287,8 @@ class CONTENT_EXPORT BrowserAccessibility {
bool* is_defined,
bool* is_mixed) const;
+ virtual base::string16 GetText() const;
+
// Returns true if the bit corresponding to the given state enum is 1.
bool HasState(ui::AXState state_enum) const;
@@ -296,9 +298,6 @@ class CONTENT_EXPORT BrowserAccessibility {
// Returns true if the caret is active on this object.
bool HasCaret() const;
- // Returns true if this node is an editable text field of any kind.
- bool IsEditableText() const;
-
// True if this is a web area, and its grandparent is a presentational iframe.
bool IsWebAreaForPresentationalIframe() const;
@@ -321,8 +320,11 @@ class CONTENT_EXPORT BrowserAccessibility {
ui::AXNode* node_;
private:
+ // |GetInnerText| recursively includes all the text from descendants such as
+ // text found in any embedded object. In contrast, |GetText| might include a
+ // special character in the place of every embedded object instead of its
+ // text, depending on the platform.
base::string16 GetInnerText() const;
- int GetInnerTextLength() const;
// If a bounding rectangle is empty, compute it based on the union of its
// children, since most accessibility APIs don't like elements with no
« no previous file with comments | « content/browser/accessibility/accessibility_win_browsertest.cc ('k') | content/browser/accessibility/browser_accessibility.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698