components/search_engines_strings.grdp - Issue 1598553003: Implement the Windows desktop search redirection feature.

Unified Diff: components/search_engines_strings.grdp

Issue 1598553003: Implement the Windows desktop search redirection feature. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: don't assume that a Browser exists + fix nits Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/search_engines/desktop_search_utils_win_unittest.cc ('K') | « components/search_engines/desktop_search_win_unittest.cc ('k') | tools/metrics/actions/actions.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/search_engines_strings.grdp

diff --git a/components/search_engines_strings.grdp b/components/search_engines_strings.grdp

new file mode 100644

index 0000000000000000000000000000000000000000..2db119c56df3fb8374d5c22e55847b3e554cf309

--- /dev/null

+++ b/components/search_engines_strings.grdp

@@ -0,0 +1,12 @@

+<?xml version="1.0" encoding="utf-8"?>

+<grit-part>

+

+ <if expr="is_win">

+ <message name="IDS_WINDOWS_DESKTOP_SEARCH_REDIRECTION_INFOBAR_MESSAGE" desc="Text shown in the infobar informing the user that a Windows desktop search has been redirected to the default search engine.">

+ Desktop searches use your default search engine (<ph name="DEFAULT_SEARCH_ENGINE_NAME">$1<ex>Google</ex></ph>).

+ </message>

+ <message name="IDS_WINDOWS_DESKTOP_SEARCH_REDIRECTION_INFOBAR_BUTTON" desc="Text of the button to go to the search engine settings page, in the infobar informing the user that a Windows desktop search has been redirected to the default search engine.">

+ Manage search settings

Peter Kasting 2016/01/20 03:03:02 Why is going to the settings useful? Is there goi

fdoray 2016/01/21 21:02:34 The user can change its default search engine from

Peter Kasting 2016/01/22 00:38:57 OK, if "disable" is done by setting the DSE to Bin

+ </message>

+ </if>

+</grit-part>