components/search_engines_strings.grdp - Issue 1598553003: Implement the Windows desktop search redirection feature.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/search_engines_strings.grdp

Issue 1598553003: Implement the Windows desktop search redirection feature. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: don't assume that a Browser exists + fix nits Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/search_engines/desktop_search_utils_win_unittest.cc ('K') | « components/search_engines/desktop_search_win_unittest.cc ('k') | tools/metrics/actions/actions.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <grit-part>

	3 <!-- Windows desktop search redirection strings. -->

	4 <if expr="is_win">

	5 <message name="IDS_WINDOWS_DESKTOP_SEARCH_REDIRECTION_INFOBAR_MESSAGE" desc= "Text shown in the infobar informing the user that a Windows desktop search has been redirected to the default search engine.">

	6 Desktop searches use your default search engine (<ph name="DEFAULT_SEARCH_ ENGINE_NAME">$1<ex>Google</ex></ph>).

	7 </message>

	8 <message name="IDS_WINDOWS_DESKTOP_SEARCH_REDIRECTION_INFOBAR_BUTTON" desc=" Text of the button to go to the search engine settings page, in the infobar info rming the user that a Windows desktop search has been redirected to the default search engine.">

	9 Manage search settings
	Peter Kasting 2016/01/20 03:03:02 Why is going to the settings useful? Is there goi Why is going to the settings useful? Is there going to be a checkbox there to disable search redirection? If not it seems somewhat unrelated to what the infobar is actually doing, and liable to just frustrate users who wanted a way to turn off this functionality. fdoray 2016/01/21 21:02:34 The user can change its default search engine from Show quoted text On 2016/01/20 03:03:02, Peter Kasting wrote: > Why is going to the settings useful? Is there going to be a checkbox there to > disable search redirection? If not it seems somewhat unrelated to what the > infobar is actually doing, and liable to just frustrate users who wanted a way > to turn off this functionality. The user can change its default search engine from the settings. It's relevant here because desktop searches are redirected to the the default search engine. ainslie@: Thoughts? Peter Kasting 2016/01/22 00:38:57 OK, if "disable" is done by setting the DSE to Bin Show quoted text On 2016/01/21 21:02:34, fdoray wrote: > On 2016/01/20 03:03:02, Peter Kasting wrote: > > Why is going to the settings useful? Is there going to be a checkbox there to > > disable search redirection? If not it seems somewhat unrelated to what the > > infobar is actually doing, and liable to just frustrate users who wanted a way > > to turn off this functionality. > > The user can change its default search engine from the settings. It's relevant > here because desktop searches are redirected to the the default search engine. OK, if "disable" is done by setting the DSE to Bing, I'm fine with this.
	10 </message>

	11 </if>

	12 </grit-part>

OLD	NEW