Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 159853008: Avoid zero resizing on prerender swap-in. (Closed)

Created:
6 years, 10 months ago by Shuhei Takahashi
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Avoid zero resizing on prerender swap-in. On swapping in a prerendered WebContents a new ContentViewCore is created with zero size. When showing the view with onShow(), a resize event is generated, causing Blink to relayout with zero size. This change workaround it by setting the view size in advance. BUG=340987 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251015

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/TabBase.java View 1 1 chunk +13 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Shuhei Takahashi (google)
Ted, could you review this change? Also please do not put this change into CQ ...
6 years, 10 months ago (2014-02-12 13:42:54 UTC) #1
Shuhei Takahashi (google)
Tested with 100 wikipedia articles, 100 yahoo answers pages, 300 random websites and all looked ...
6 years, 10 months ago (2014-02-13 01:30:28 UTC) #2
Ted C
lgtm
6 years, 10 months ago (2014-02-13 01:44:31 UTC) #3
Shuhei Takahashi
Thanks for reviewing! Sending to CQ.
6 years, 10 months ago (2014-02-13 01:47:40 UTC) #4
Shuhei Takahashi
The CQ bit was checked by nya@chromium.org
6 years, 10 months ago (2014-02-13 01:47:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nya@chromium.org/159853008/30001
6 years, 10 months ago (2014-02-13 01:51:30 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 03:06:22 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=263168
6 years, 10 months ago (2014-02-13 03:06:22 UTC) #8
Shuhei Takahashi
The CQ bit was checked by nya@chromium.org
6 years, 10 months ago (2014-02-13 03:39:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nya@chromium.org/159853008/30001
6 years, 10 months ago (2014-02-13 03:41:11 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 15:17:20 UTC) #11
Message was sent while issue was closed.
Change committed as 251015

Powered by Google App Engine
This is Rietveld 408576698