Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 159853004: Ensure that every Document has a single, distinct template content ownerDocument (Closed)

Created:
6 years, 10 months ago by adamk
Modified:
6 years, 10 months ago
Reviewers:
rafaelw
CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org, Inactive
Visibility:
Public.

Description

Ensure that every Document has a single, distinct template content ownerDocument This avoids several bugs where templates would erroneously share their content ownerDocuments with themselves, leading to such badness as custom elements being instantiated inside templates or template.content.ownerDocument.defaultView being non-null. Also cleans up various code in Document: templateDocument() is gone, with its callers switched to the new isTemplateDocument() method, and setTemplateDocumentHost() has been removed from Document's public interface, since it should only be set by Document itself. Spec bug: https://www.w3.org/Bugs/Public/show_bug.cgi?id=23990 Relevant HTML spec change: http://html5.org/tools/web-apps-tracker?from=8350&to=8351 R=rafaelw@chromium.org BUG=325442, 342601 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166973

Patch Set 1 #

Patch Set 2 : Suppress expected w3c test failures #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -18 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +5 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/HTMLTemplateElement/ownerDocument-import.html View 1 chunk +19 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/HTMLTemplateElement/ownerDocument-import-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/HTMLTemplateElement/ownerDocument-no-defaultView.html View 1 chunk +8 lines, -0 lines 0 comments Download
A + LayoutTests/fast/dom/HTMLTemplateElement/ownerDocument-no-defaultView-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A LayoutTests/fast/dom/HTMLTemplateElement/resources/template-import.html View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/ContainerNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.h View 2 chunks +2 lines, -11 lines 0 comments Download
M Source/core/dom/Document.cpp View 3 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
adamk
6 years, 10 months ago (2014-02-11 21:29:22 UTC) #1
rafaelw
lgtm
6 years, 10 months ago (2014-02-11 22:28:35 UTC) #2
adamk
The CQ bit was checked by adamk@chromium.org
6 years, 10 months ago (2014-02-11 23:52:32 UTC) #3
adamk
The CQ bit was unchecked by adamk@chromium.org
6 years, 10 months ago (2014-02-12 00:13:39 UTC) #4
adamk
The CQ bit was checked by adamk@chromium.org
6 years, 10 months ago (2014-02-12 00:13:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/159853004/60001
6 years, 10 months ago (2014-02-12 02:00:46 UTC) #6
adamk
The CQ bit was unchecked by adamk@chromium.org
6 years, 10 months ago (2014-02-12 06:45:06 UTC) #7
adamk
The CQ bit was checked by adamk@chromium.org
6 years, 10 months ago (2014-02-12 06:45:12 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-12 07:42:04 UTC) #9
Message was sent while issue was closed.
Change committed as 166973

Powered by Google App Engine
This is Rietveld 408576698