components/autofill/core/browser/autofill_manager.cc - Issue 159853003: Moving the autofill enum from blink side to browser side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_manager.cc

Issue 159853003: Moving the autofill enum from blink side to browser side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_external_delegate_unittest.cc ('k') | components/autofill/core/browser/autofill_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_manager.cc

diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc

index 5aab9dc63be56d128b4c9ca763a4aae22e0aed7e..0ff9a81de444155c400bc3203bc8000ea44ded2b 100644

--- a/components/autofill/core/browser/autofill_manager.cc

+++ b/components/autofill/core/browser/autofill_manager.cc

@@ -35,6 +35,7 @@

#include "components/autofill/core/browser/personal_data_manager.h"

#include "components/autofill/core/browser/phone_number.h"

#include "components/autofill/core/browser/phone_number_i18n.h"

+#include "components/autofill/core/browser/popup_item_ids.h"

#include "components/autofill/core/common/autofill_data_validation.h"

#include "components/autofill/core/common/autofill_pref_names.h"

#include "components/autofill/core/common/autofill_switches.h"

@@ -44,7 +45,6 @@

#include "components/autofill/core/common/password_form_fill_data.h"

#include "components/user_prefs/pref_registry_syncable.h"

#include "grit/component_strings.h"

-#include "third_party/WebKit/public/web/WebAutofillClient.h"

#include "ui/base/l10n/l10n_util.h"

#include "ui/gfx/rect.h"

#include "url/gurl.h"

@@ -416,8 +416,7 @@ void AutofillManager::OnQueryFormFieldAutofill(int query_id,

values.assign(1, l10n_util::GetStringUTF16(warning));

labels.assign(1, base::string16());

icons.assign(1, base::string16());

- unique_ids.assign(1,

- blink::WebAutofillClient::MenuItemIDWarningMessage);

+ unique_ids.assign(1, POPUP_ITEM_ID_WARNING_MESSAGE);

} else {

bool section_is_autofilled =

SectionIsAutofilled(*form_structure, form,