chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm - Issue 159853003: Moving the autofill enum from blink side to browser side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm

Issue 159853003: Moving the autofill enum from blink side to browser side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc ('k') | chrome/browser/ui/gtk/autofill/autofill_popup_view_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm b/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm

index 01cb1409e0115cdd02d7d41875b4ecd6329c9ca6..4ee0bba649283df15863fdd8d70b060d2e742fed 100644

--- a/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm

+++ b/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm

@@ -9,8 +9,8 @@

#include "chrome/browser/ui/autofill/autofill_popup_controller.h"

#include "chrome/browser/ui/autofill/popup_constants.h"

#include "chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.h"

+#include "components/autofill/core/browser/popup_item_ids.h"

#include "grit/ui_resources.h"

-#include "third_party/WebKit/public/web/WebAutofillClient.h"

#include "ui/base/resource/resource_bundle.h"

#include "ui/gfx/font_list.h"

#include "ui/gfx/image/image.h"

@@ -135,8 +135,7 @@ NSColor* SubtextColor() {

if (!NSIntersectsRect(rowBounds, dirtyRect))

continue;

- if (controller_->identifiers()[i] ==

- blink::WebAutofillClient::MenuItemIDSeparator) {

+ if (controller_->identifiers()[i] == autofill::POPUP_ITEM_ID_SEPARATOR) {

[self drawSeparatorWithBounds:rowBounds];

} else {

NSString* name = SysUTF16ToNSString(controller_->names()[i]);