OLD | NEW |
---|---|
(Empty) | |
1 // Copyright 2013 The Chromium Authors. All rights reserved. | |
Ilya Sherman
2014/02/11 22:21:33
nit: 2014
gnana
2014/02/12 13:34:09
Done.
| |
2 // Use of this source code is governed by a BSD-style license that can be | |
3 // found in the LICENSE file. | |
4 | |
5 // Contains enum specific to the Autofill component. | |
6 | |
7 #ifndef COMPONENTS_AUTOFILL_CORE_COMMON_AUTOFILL_ENUMS_H_ | |
8 #define COMPONENTS_AUTOFILL_CORE_COMMON_AUTOFILL_ENUMS_H_ | |
9 | |
10 #include <stddef.h> // For size_t | |
Ilya Sherman
2014/02/11 22:21:33
nit: size_t isn't used in this header file, so the
gnana
2014/02/12 13:34:09
Done.
| |
11 | |
12 namespace autofill { | |
13 | |
14 enum { | |
Ilya Sherman
2014/02/11 22:21:33
nit: The enum should be named, probably "MenuItemI
gnana
2014/02/12 13:34:09
Done.
| |
15 MenuItemIDAutocompleteEntry = 0, | |
blundell
2014/02/11 20:30:33
I would think this most naturally belongs in autof
gnana
2014/02/12 13:34:09
Applied the git cl format, to resolve indentation
| |
16 MenuItemIDWarningMessage = -1, | |
17 MenuItemIDPasswordEntry = -2, | |
18 MenuItemIDSeparator = -3, | |
19 MenuItemIDClearForm = -4, | |
Ilya Sherman
2014/02/11 22:21:33
nit: Rather than "Menu", "Popup" or "PopupMenu" wo
gnana
2014/02/12 13:34:09
Done.
| |
20 MenuItemIDAutofillOptions = -5, | |
21 MenuItemIDDataListEntry = -6 | |
Ilya Sherman
2014/02/11 22:21:33
nit: Chromium enum values should be formatted in A
gnana
2014/02/12 13:34:09
Done.
| |
22 }; | |
23 | |
24 | |
25 } // namespace autofill | |
26 | |
27 #endif // COMPONENTS_AUTOFILL_CORE_COMMON_AUTOFILL_ENUMS_H_ | |
OLD | NEW |