Moving the autofill enum from blink side to browser side

components/autofill/core/common/autofill_enums.h

+// Copyright 2013 The Chromium Authors. All rights reserved.

[Ilya Sherman, 2014/02/11 22:21:33]

nit: 2014

[gnana, 2014/02/12 13:34:09]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Contains enum specific to the Autofill component.
+
+#ifndef COMPONENTS_AUTOFILL_CORE_COMMON_AUTOFILL_ENUMS_H_
+#define COMPONENTS_AUTOFILL_CORE_COMMON_AUTOFILL_ENUMS_H_
+
+#include <stddef.h>         // For size_t

[Ilya Sherman, 2014/02/11 22:21:33]

nit: size_t isn't used in this header file, so there's probably no need for this
#include.

[gnana, 2014/02/12 13:34:09]

Done.

+
+namespace autofill {
+
+    enum {

[Ilya Sherman, 2014/02/11 22:21:33]

nit: The enum should be named, probably "MenuItemID", or "PopupItemID" if you
take my suggestion below.

[gnana, 2014/02/12 13:34:09]

Done.

+        MenuItemIDAutocompleteEntry = 0,

[blundell, 2014/02/11 20:30:33]

I would think this most naturally belongs in autofill_popup_controller.h. Also,
the indentation here isn't matching Chromium style (you could consider just
running "git cl format" over your patch before uploading -- it will take care of
a lot of these style issues).

[gnana, 2014/02/12 13:34:09]

Applied the git cl format, to resolve indentation and other style issues.
I tried moving this to autofill_popup_controller.h. But including
autofill_popup_controller.h in autofill_external_deleagate.cc and
autofill_manager.cc causes presubmit errors.

+        MenuItemIDWarningMessage = -1,
+        MenuItemIDPasswordEntry = -2,
+        MenuItemIDSeparator = -3,
+        MenuItemIDClearForm = -4,

[Ilya Sherman, 2014/02/11 22:21:33]

nit: Rather than "Menu", "Popup" or "PopupMenu" would probably be slightly more
consistent with the code that uses this enum.

[gnana, 2014/02/12 13:34:09]

Done.

+        MenuItemIDAutofillOptions = -5,
+        MenuItemIDDataListEntry = -6

[Ilya Sherman, 2014/02/11 22:21:33]

nit: Chromium enum values should be formatted in ALL_CAPS.

[gnana, 2014/02/12 13:34:09]

Done.

+    };
+
+
+}  // namespace autofill
+
+#endif  // COMPONENTS_AUTOFILL_CORE_COMMON_AUTOFILL_ENUMS_H_