components/autofill/core/browser/popup_item_ids.h - Issue 159853003: Moving the autofill enum from blink side to browser side

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/autofill/core/browser/popup_item_ids.h

Issue 159853003: Moving the autofill enum from blink side to browser side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase & incorporated review comments Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // Contains enum specific to the Autofill component.
	blundell 2014/02/14 16:01:11 This comment should change to be about what this e This comment should change to be about what this enum is. gnana 2014/02/14 17:08:46 Done. Show quoted text On 2014/02/14 16:01:11, blundell wrote: > This comment should change to be about what this enum is. Done.
	6

	7 #ifndef COMPONENTS_AUTOFILL_CORE_COMMON_AUTOFILL_ENUMS_H_
	blundell 2014/02/14 16:01:11 This should change. This should change. gnana 2014/02/14 17:08:46 Done. Show quoted text On 2014/02/14 16:01:11, blundell wrote: > This should change. Done.
	8 #define COMPONENTS_AUTOFILL_CORE_COMMON_AUTOFILL_ENUMS_H_

	9

	10 namespace autofill {

	11

	12 enum PopupItemId {

	13 POPUP_ITEM_ID_AUTOCOMPLETE_ENTRY = 0,

	14 POPUP_ITEM_ID_WARNING_MESSAGE = -1,

	15 POPUP_ITEM_ID_PASSWORD_ENTRY = -2,

	16 POPUP_ITEM_ID_SEPARATOR = -3,

	17 POPUP_ITEM_ID_CLEAR_FORM = -4,

	18 POPUP_ITEM_ID_AUTOFILL_OPTIONS = -5,

	19 POPUP_ITEM_ID_DATALIST_ENTRY = -6

	20 };

	21

	22 } // namespace autofill

	23

	24 #endif // COMPONENTS_AUTOFILL_CORE_COMMON_AUTOFILL_ENUMS_H_

OLD	NEW

« no previous file with comments | « components/autofill/core/browser/autofill_manager_unittest.cc ('k') | no next file » | no next file with comments »