Moving the autofill enum from blink side to browser side

components/autofill/core/common/autofill_enums.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Contains enum specific to the Autofill component.
+
+#ifndef COMPONENTS_AUTOFILL_CORE_COMMON_AUTOFILL_ENUMS_H_
+#define COMPONENTS_AUTOFILL_CORE_COMMON_AUTOFILL_ENUMS_H_
+
+namespace autofill {
+
+enum PopUpItemId {

[Ilya Sherman, 2014/02/13 22:30:03]

nit: "PopUp" -> "Popup"

[gnana, 2014/02/14 09:02:06]

Done.

+  POPUP_ITEM_ID_AUTOCOMPLETE_ENTRY = 0,
+  POPUP_ITEM_ID_WARNING_MESSAGE = -1,
+  POPUP_ITEM_ID_PASSWORD_ENTRY = -2,
+  POPUP_ITEM_ID_SEPERATOR = -3,
+  POPUP_ITEM_ID_CLEAR_FORM = -4,
+  POPUP_ITEM_ID_AUTOFILL_OPTIONS = -5,
+  POPUP_ITEM_ID_DATALIST_ENTRY = -6
+};
+
+}  // namespace autofill
+
+#endif  // COMPONENTS_AUTOFILL_CORE_COMMON_AUTOFILL_ENUMS_H_

[Ilya Sherman, 2014/02/13 22:30:03]

IMO, Colin's suggestion of moving this enum to autofill_popup_delegate.h makes
sense.

If we decide against that, though, then I'd recommend naming this file something
more specific than "autofill_enums.h" -- perhaps "popup_item_ids.h" -- and
moving it to //components/autofill/core/browser rather than
//components/autofill/core/common, assuming that there are no
//components/autofill/content/renderer dependencies on this enum.

[gnana, 2014/02/14 09:02:06]

Done.