sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart - Issue 15985005: Re-apply: Fix type propagation bug by always narrowing types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart

Issue 15985005: Re-apply: Fix type propagation bug by always narrowing types. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart ('k') | tests/compiler/dart2js/compiler_helper.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart (revision 23578)

+++ sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart (working copy)

@@ -152,15 +152,19 @@

TypeMask get typeType => internal.typeType;

TypeMask getReturnTypeOfElement(Element element) {

+ if (compiler.disableTypeInference) return dynamicType;

return internal.getReturnTypeOfElement(element);

}

TypeMask getTypeOfElement(Element element) {

+ if (compiler.disableTypeInference) return dynamicType;

return internal.getTypeOfElement(element);

}

TypeMask getTypeOfNode(Element owner, Node node) {

+ if (compiler.disableTypeInference) return dynamicType;

return internal.getTypeOfNode(owner, node);

}

TypeMask getTypeOfSelector(Selector selector) {

+ if (compiler.disableTypeInference) return dynamicType;

return internal.getTypeOfSelector(selector);

}

@@ -817,7 +821,7 @@

return isTypeValuable(result);

});

if (result == null) {

- result = dynamicType;

+ result = new TypeMask.nonNullEmpty();

}

return result;

}