build/get_landmines.py - Issue 1598493004: Change default Windows compiler to VS 2015

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/get_landmines.py

Issue 1598493004: Change default Windows compiler to VS 2015 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove duplicate include paths and explain in comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/get_landmines.py

diff --git a/build/get_landmines.py b/build/get_landmines.py

index 4139957129918785c082e741f315c1057002c936..62116f91e192b7603bf4a2c2a90c77f44a43e431 100755

--- a/build/get_landmines.py

+++ b/build/get_landmines.py

@@ -52,9 +52,7 @@ def print_landmines():

print "Switched win x64 trybots from VS2010 to VS2012."

if (platform() == 'win' and builder() == 'ninja' and

gyp_msvs_version().startswith('2013')):

- print "Switched win from VS2010 to VS2013."

- print "Update to VS2013 Update 2."

- print "Update to VS2013 Update 4."

+ print "Switch to VS2013"

if (platform() == 'win' and gyp_msvs_version().startswith('2015')):

print 'Switch to VS2015'

print 'Need to clobber everything due to an IDL change in r154579 (blink)'