Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 1598433006: [ast cleanup] Remove unnecessary frozen_ bit from ModuleDescriptor (Closed)

Created:
4 years, 11 months ago by adamk
Modified:
4 years, 11 months ago
Reviewers:
Dan Ehrenberg, rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ast cleanup] Remove unnecessary frozen_ bit from ModuleDescriptor This may have made more sense in the old module design (where "unification" was a thing), but as-is it's only used for a few asserts in debug mode. These asserts don't make much sense inside ModuleDescriptor; instead, as the modules implementation is fleshed out, I expect the appropriate replacement asserts to show up at the use of the ModuleDescriptor. Committed: https://crrev.com/dc6a5939188abd3c61323cc52a52fbf3000ca076 Cr-Commit-Position: refs/heads/master@{#33345}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -18 lines) Patch
M src/ast/modules.h View 3 chunks +3 lines, -16 lines 0 comments Download
M src/ast/modules.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/parsing/parser.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
adamk
4 years, 11 months ago (2016-01-15 23:57:47 UTC) #2
adamk
+littledan (just a cleanup patch)
4 years, 11 months ago (2016-01-15 23:58:15 UTC) #5
Dan Ehrenberg
lgtm
4 years, 11 months ago (2016-01-16 00:04:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1598433006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1598433006/1
4 years, 11 months ago (2016-01-16 00:04:56 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-16 00:42:33 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-16 00:42:55 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dc6a5939188abd3c61323cc52a52fbf3000ca076
Cr-Commit-Position: refs/heads/master@{#33345}

Powered by Google App Engine
This is Rietveld 408576698