Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Issue 1598433004: Deflake Android fullscreen tests. (Closed)

Created:
4 years, 11 months ago by Ted C
Modified:
4 years, 11 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deflake Android fullscreen tests. The flaky tests all dealt with manually hiding the top controls based on user gesture. The flakiness comes from the fact that determining whether the top controls can be scrolled is controlled in the renderer compositor and even if we were to monitor Tab.java's latest value that it has sent, it does not take affect until some time later. As a result, this adds a new function that attempts to scroll the top controls in a loop until it takes affect and then proceeds. BUG=488393, 339668, 512299 Committed: https://crrev.com/326db8c916155a1c3f5655700731c6b4991857f0 Cr-Commit-Position: refs/heads/master@{#369880}

Patch Set 1 #

Patch Set 2 : Make function to disable browser overrides #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -63 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/fullscreen/FullscreenManagerTest.java View 1 18 chunks +109 lines, -63 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Ted C
PTAL
4 years, 11 months ago (2016-01-15 21:48:26 UTC) #2
gone
lgtm % offline comments about making a function for dealing with that disableBrowserOverrides call on ...
4 years, 11 months ago (2016-01-15 22:53:57 UTC) #3
Ted C
Offline comment addressed
4 years, 11 months ago (2016-01-15 22:56:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1598433004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1598433004/20001
4 years, 11 months ago (2016-01-15 22:56:33 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-15 23:38:49 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 23:40:00 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/326db8c916155a1c3f5655700731c6b4991857f0
Cr-Commit-Position: refs/heads/master@{#369880}

Powered by Google App Engine
This is Rietveld 408576698