Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 159841: Linux: preload ffmpeg in the zygote. (Closed)

Created:
11 years, 4 months ago by agl
Modified:
9 years, 7 months ago
Reviewers:
awong
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Linux: preload ffmpeg in the zygote. When using the sandbox, the renderer cannot load the ffmpeg shared objects from disk. So we load them in the zygote before the sandbox is started. (Note that this doesn't get media working, but it's a start.) BUG=18329

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M chrome/browser/zygote_main_linux.cc View 3 chunks +7 lines, -0 lines 0 comments Download
M third_party/ffmpeg/ffmpeg.gyp View 1 chunk +3 lines, -1 line 2 comments Download

Messages

Total messages: 5 (0 generated)
agl
11 years, 4 months ago (2009-08-04 01:11:54 UTC) #1
awong
LGTM with one question. http://codereview.chromium.org/159841/diff/1/3 File third_party/ffmpeg/ffmpeg.gyp (right): http://codereview.chromium.org/159841/diff/1/3#newcode26 Line 26: 'avutil-50.sigs', what? really? What ...
11 years, 4 months ago (2009-08-04 01:17:10 UTC) #2
agl
http://codereview.chromium.org/159841/diff/1/3 File third_party/ffmpeg/ffmpeg.gyp (right): http://codereview.chromium.org/159841/diff/1/3#newcode26 Line 26: 'avutil-50.sigs', On 2009/08/04 01:17:10, awong wrote: > what? ...
11 years, 4 months ago (2009-08-04 01:18:46 UTC) #3
awong
On Mon, Aug 3, 2009 at 6:18 PM, <agl@chromium.org> wrote: > > http://codereview.chromium.org/159841/diff/1/3 > File ...
11 years, 4 months ago (2009-08-04 01:21:12 UTC) #4
awong
11 years, 4 months ago (2009-08-06 18:39:34 UTC) #5
On 2009/08/04 01:21:12, awong wrote:
> On Mon, Aug 3, 2009 at 6:18 PM, <agl@chromium.org> wrote:
> 
> >
> > http://codereview.chromium.org/159841/diff/1/3
> > File third_party/ffmpeg/ffmpeg.gyp (right):
> >
> > http://codereview.chromium.org/159841/diff/1/3#newcode26
> > Line 26: 'avutil-50.sigs',
> > On 2009/08/04 01:17:10, awong wrote:
> >
> >> what?  really?  What happens if it's not?  I didn't think it should
> >>
> > matter...
> >
> > It doesn't load otherwise. avcodec depends on avutil. If avutil isn't
> > loaded first then libc will try to find avutil using the order listed in
> > the manpage. Since I don't have an system avutil which works, it fails
> > to load avcodec.
> 
> 
> I thought that's why chrome-wrapper set LD_LIBRARY_PATH so that the
> libraries could self-resolve.  Making it work independent of the
> LD_LIBRARY_PATH settings is nice though.
> 
> -Albert
> 

I think this got checked in...should this be closed?

Powered by Google App Engine
This is Rietveld 408576698