Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: chrome/browser/extensions/permissions_updater_unittest.cc

Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/permissions_updater_unittest.cc
diff --git a/chrome/browser/extensions/permissions_updater_unittest.cc b/chrome/browser/extensions/permissions_updater_unittest.cc
index b13888695f9071ab9c2f7f61f57e78956881db69..cf55dc74f4d84eba776347abb55606692f916b4b 100644
--- a/chrome/browser/extensions/permissions_updater_unittest.cc
+++ b/chrome/browser/extensions/permissions_updater_unittest.cc
@@ -127,7 +127,8 @@ TEST_F(PermissionsUpdaterTest, AddAndRemovePermissions) {
// Make sure it loaded properly.
scoped_refptr<const PermissionSet> permissions =
extension->GetActivePermissions();
- ASSERT_EQ(*default_permissions.get(), *extension->GetActivePermissions());
+ ASSERT_EQ(*default_permissions.get(),
+ *extension->GetActivePermissions().get());
// Add a few permissions.
APIPermissionSet apis;
@@ -154,7 +155,8 @@ TEST_F(PermissionsUpdaterTest, AddAndRemovePermissions) {
// Make sure the extension's active permissions reflect the change.
scoped_refptr<PermissionSet> active_permissions =
PermissionSet::CreateUnion(default_permissions.get(), delta.get());
- ASSERT_EQ(*active_permissions.get(), *extension->GetActivePermissions());
+ ASSERT_EQ(*active_permissions.get(),
+ *extension->GetActivePermissions().get());
// Verify that the new granted and active permissions were also stored
// in the extension preferences. In this case, the granted permissions should
@@ -188,7 +190,8 @@ TEST_F(PermissionsUpdaterTest, AddAndRemovePermissions) {
// Make sure the extension's active permissions reflect the change.
active_permissions =
PermissionSet::CreateDifference(active_permissions.get(), delta.get());
- ASSERT_EQ(*active_permissions.get(), *extension->GetActivePermissions());
+ ASSERT_EQ(*active_permissions.get(),
+ *extension->GetActivePermissions().get());
// Verify that the extension prefs hold the new active permissions and the
// same granted permissions.
« no previous file with comments | « chrome/browser/extensions/permissions_updater.cc ('k') | chrome/browser/extensions/sandboxed_unpacker_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698