Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_launch_unittest.cc

Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "chrome/common/chrome_switches.h" 6 #include "chrome/common/chrome_switches.h"
7 #include "chrome/common/extensions/extension.h" 7 #include "chrome/common/extensions/extension.h"
8 #include "chrome/common/extensions/extension_manifest_constants.h" 8 #include "chrome/common/extensions/extension_manifest_constants.h"
9 #include "chrome/common/extensions/manifest_handlers/app_launch_info.h" 9 #include "chrome/common/extensions/manifest_handlers/app_launch_info.h"
10 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 10 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
11 #include "extensions/common/error_utils.h" 11 #include "extensions/common/error_utils.h"
12 #include "testing/gtest/include/gtest/gtest.h" 12 #include "testing/gtest/include/gtest/gtest.h"
13 13
14 namespace errors = extension_manifest_errors; 14 namespace errors = extension_manifest_errors;
15 namespace keys = extension_manifest_keys; 15 namespace keys = extension_manifest_keys;
16 16
17 namespace extensions { 17 namespace extensions {
18 18
19 class AppLaunchManifestTest : public ExtensionManifestTest { 19 class AppLaunchManifestTest : public ExtensionManifestTest {
20 }; 20 };
21 21
22 TEST_F(AppLaunchManifestTest, AppLaunchContainer) { 22 TEST_F(AppLaunchManifestTest, AppLaunchContainer) {
23 scoped_refptr<Extension> extension; 23 scoped_refptr<Extension> extension;
24 24
25 extension = LoadAndExpectSuccess("launch_tab.json"); 25 extension = LoadAndExpectSuccess("launch_tab.json");
26 EXPECT_EQ(extension_misc::LAUNCH_TAB, 26 EXPECT_EQ(extension_misc::LAUNCH_TAB,
27 AppLaunchInfo::GetLaunchContainer(extension)); 27 AppLaunchInfo::GetLaunchContainer(extension.get()));
28 28
29 extension = LoadAndExpectSuccess("launch_panel.json"); 29 extension = LoadAndExpectSuccess("launch_panel.json");
30 EXPECT_EQ(extension_misc::LAUNCH_PANEL, 30 EXPECT_EQ(extension_misc::LAUNCH_PANEL,
31 AppLaunchInfo::GetLaunchContainer(extension)); 31 AppLaunchInfo::GetLaunchContainer(extension.get()));
32 32
33 extension = LoadAndExpectSuccess("launch_default.json"); 33 extension = LoadAndExpectSuccess("launch_default.json");
34 EXPECT_EQ(extension_misc::LAUNCH_TAB, 34 EXPECT_EQ(extension_misc::LAUNCH_TAB,
35 AppLaunchInfo::GetLaunchContainer(extension)); 35 AppLaunchInfo::GetLaunchContainer(extension.get()));
36 36
37 extension = LoadAndExpectSuccess("launch_width.json"); 37 extension = LoadAndExpectSuccess("launch_width.json");
38 EXPECT_EQ(640, AppLaunchInfo::GetLaunchWidth(extension)); 38 EXPECT_EQ(640, AppLaunchInfo::GetLaunchWidth(extension.get()));
39 39
40 extension = LoadAndExpectSuccess("launch_height.json"); 40 extension = LoadAndExpectSuccess("launch_height.json");
41 EXPECT_EQ(480, AppLaunchInfo::GetLaunchHeight(extension)); 41 EXPECT_EQ(480, AppLaunchInfo::GetLaunchHeight(extension.get()));
42 42
43 Testcase testcases[] = { 43 Testcase testcases[] = {
44 Testcase("launch_window.json", errors::kInvalidLaunchContainer), 44 Testcase("launch_window.json", errors::kInvalidLaunchContainer),
45 Testcase("launch_container_invalid_type.json", 45 Testcase("launch_container_invalid_type.json",
46 errors::kInvalidLaunchContainer), 46 errors::kInvalidLaunchContainer),
47 Testcase("launch_container_invalid_value.json", 47 Testcase("launch_container_invalid_value.json",
48 errors::kInvalidLaunchContainer), 48 errors::kInvalidLaunchContainer),
49 Testcase("launch_container_without_launch_url.json", 49 Testcase("launch_container_without_launch_url.json",
50 errors::kLaunchURLRequired), 50 errors::kLaunchURLRequired),
51 Testcase("launch_width_invalid.json", 51 Testcase("launch_width_invalid.json",
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 ErrorUtils::FormatErrorMessage( 103 ErrorUtils::FormatErrorMessage(
104 errors::kInvalidLaunchValue, 104 errors::kInvalidLaunchValue,
105 keys::kLaunchWebURL)) 105 keys::kLaunchWebURL))
106 }; 106 };
107 RunTestcases(testcases, arraysize(testcases), 107 RunTestcases(testcases, arraysize(testcases),
108 EXPECT_TYPE_ERROR); 108 EXPECT_TYPE_ERROR);
109 109
110 scoped_refptr<Extension> extension; 110 scoped_refptr<Extension> extension;
111 extension = LoadAndExpectSuccess("launch_local_path.json"); 111 extension = LoadAndExpectSuccess("launch_local_path.json");
112 EXPECT_EQ(extension->url().spec() + "launch.html", 112 EXPECT_EQ(extension->url().spec() + "launch.html",
113 AppLaunchInfo::GetFullLaunchURL(extension).spec()); 113 AppLaunchInfo::GetFullLaunchURL(extension.get()).spec());
114 114
115 extension = LoadAndExpectSuccess("launch_local_path_localized.json"); 115 extension = LoadAndExpectSuccess("launch_local_path_localized.json");
116 EXPECT_EQ(extension->url().spec() + "launch.html", 116 EXPECT_EQ(extension->url().spec() + "launch.html",
117 AppLaunchInfo::GetFullLaunchURL(extension).spec()); 117 AppLaunchInfo::GetFullLaunchURL(extension.get()).spec());
118 118
119 LoadAndExpectError("launch_web_url_relative.json", 119 LoadAndExpectError("launch_web_url_relative.json",
120 ErrorUtils::FormatErrorMessage( 120 ErrorUtils::FormatErrorMessage(
121 errors::kInvalidLaunchValue, 121 errors::kInvalidLaunchValue,
122 keys::kLaunchWebURL)); 122 keys::kLaunchWebURL));
123 123
124 extension = LoadAndExpectSuccess("launch_web_url_absolute.json"); 124 extension = LoadAndExpectSuccess("launch_web_url_absolute.json");
125 EXPECT_EQ(GURL("http://www.google.com/launch.html"), 125 EXPECT_EQ(GURL("http://www.google.com/launch.html"),
126 AppLaunchInfo::GetFullLaunchURL(extension)); 126 AppLaunchInfo::GetFullLaunchURL(extension.get()));
127 extension = LoadAndExpectSuccess("launch_web_url_localized.json"); 127 extension = LoadAndExpectSuccess("launch_web_url_localized.json");
128 EXPECT_EQ(GURL("http://www.google.com/launch.html"), 128 EXPECT_EQ(GURL("http://www.google.com/launch.html"),
129 AppLaunchInfo::GetFullLaunchURL(extension)); 129 AppLaunchInfo::GetFullLaunchURL(extension.get()));
130 } 130 }
131 131
132 } // namespace extensions 132 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698