Add tests for the video player in Files.app.

chrome/browser/chromeos/extensions/file_manager/file_manager_browsertest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Browser test for basic Chrome OS file manager functionality:
 //  - The file list is updated when a file is added externally to the Downloads
 //    folder.
 //  - Selecting a file and copy-pasting it with the keyboard copies the file.
 //  - Selecting a file and pressing delete deletes it.
 
@@ skipping 48 matching lines @@
   const char* target_name;  // Target file or directory name.
   const char* mime_type;
   SharedOption shared_option;
   const char* last_modified_time_as_string;
 };
 
 TestEntryInfo kTestEntrySetCommon[] = {
   { FILE, "text.txt", "hello.txt", "text/plain", NONE, "4 Sep 1998 12:34:56" },
   { FILE, "image.png", "My Desktop Background.png", "text/plain", NONE,
     "18 Jan 2038 01:02:03" },
+  { FILE, "music.ogg", "Beautiful Song.ogg", "text/plain", NONE,
+    "12 Nov 2086 12:00:00" },
   { FILE, "video.ogv", kKeyboardTestFileName, "text/plain", NONE,
     "4 July 2012 10:35:00" },
   { DIRECTORY, "", "photos", NULL, NONE, "1 Jan 1980 23:59:59" },
   { DIRECTORY, "", ".warez", NULL, NONE, "26 Oct 1985 13:39" }
 };
 
 TestEntryInfo kTestEntrySetDriveOnly[] = {
   { FILE, "", "Test Document", "application/vnd.google-apps.document", NONE,
     "10 Apr 2013 16:20:00" },
   { FILE, "", "Test Shared Document", "application/vnd.google-apps.document",
@@ skipping 497 matching lines @@
   // Creates test files and directories.
   void CreateTestEntries(TestVolume* volume, const TestEntryInfo* entries,
                          size_t num_entries);
 
   // Runs the file display test on the passed |volume|, shared by subclasses.
   void DoTestFileDisplay(TestVolume* volume);
 
   // Runs the gallery open test on the passed |volume|, shared by subclasses.
   void DoTestGalleryOpen(TestVolume* volume);
 
+  // Runs the audio open test on the passed |volume|, shared by subclasses.
+  void DoTestAudioOpen(TestVolume* volume);
+
+  // Runs the video open test on the passed |volume|, shared by subclasses.
+  void DoTestVideoOpen(TestVolume* volume);
+
   // Runs the keyboard copy test on the passed |volume|, shared by subclasses.
   void DoTestKeyboardCopy(TestVolume* volume);
 
   // Runs the keyboard delete test on the passed |volume|, shared by subclasses.
   void DoTestKeyboardDelete(TestVolume* volume);
 };
 
 void FileManagerBrowserTestBase::SetUpCommandLine(CommandLine* command_line) {
   bool in_guest_mode = GetParam();
   if (in_guest_mode) {
@@ skipping 42 matching lines @@
 
   ASSERT_TRUE(catcher.GetNextResult()) << catcher.message();
 }
 
 void FileManagerBrowserTestBase::DoTestGalleryOpen(TestVolume* volume) {
   ResultCatcher catcher;
   StartTest("galleryOpen" + volume->GetName());
   ASSERT_TRUE(catcher.GetNextResult()) << catcher.message();
 }
 
+void FileManagerBrowserTestBase::DoTestAudioOpen(TestVolume* volume) {
+  ResultCatcher catcher;
+  StartTest("audioOpen" + volume->GetName());

[hashimoto, 2013/05/28 07:54:12]

Can't these method inlined in the test bodies?
If we really want to eliminate duplication of "ResultCatcher cathcer;" and
"ASSERT_TRUE(catcher.GetNextResult()) << catcher.message();", these lines should
be included in StartTest() instead. (currently this is not possible because of
DoTestFileDisplay(), though.)
Also, "audioOpenDrive" is more reader-friendly than "audioOpen" +
volume->GetName().

[mtomasz, 2013/05/28 10:26:38]

Sure, they can. I were this way for consistency. Fixed, done.

+  ASSERT_TRUE(catcher.GetNextResult()) << catcher.message();
+}
+
+void FileManagerBrowserTestBase::DoTestVideoOpen(TestVolume* volume) {
+  ResultCatcher catcher;
+  StartTest("videoOpen" + volume->GetName());
+  ASSERT_TRUE(catcher.GetNextResult()) << catcher.message();
+}
+
 void FileManagerBrowserTestBase::DoTestKeyboardCopy(TestVolume* volume) {
   base::FilePath copy_path =
       volume->GetRootPath().AppendASCII(kKeyboardTestFileCopyName);
   ASSERT_FALSE(volume->PathExists(copy_path));
 
   ResultCatcher catcher;
   ASSERT_NO_FATAL_FAILURE(StartTest("keyboardCopy" + volume->GetName()));
 
   const int64 kKeyboardTestFileSize = 59943;
 
@@ skipping 115 matching lines @@
 }
 
 IN_PROC_BROWSER_TEST_P(FileManagerBrowserLocalTest, TestGalleryOpen) {
   DoTestGalleryOpen(&volume_);
 }
 
 IN_PROC_BROWSER_TEST_P(FileManagerBrowserDriveTest, TestGalleryOpen) {
   DoTestGalleryOpen(&volume_);
 }
 
+IN_PROC_BROWSER_TEST_P(FileManagerBrowserLocalTest, TestAudioOpen) {
+  DoTestAudioOpen(&volume_);
+}
+
+IN_PROC_BROWSER_TEST_P(FileManagerBrowserDriveTest, TestAudioOpen) {
+  DoTestAudioOpen(&volume_);
+}
+
+IN_PROC_BROWSER_TEST_P(FileManagerBrowserLocalTest, TestVideoOpen) {
+  DoTestVideoOpen(&volume_);
+}
+
+IN_PROC_BROWSER_TEST_P(FileManagerBrowserDriveTest, TestVideoOpen) {
+  DoTestVideoOpen(&volume_);
+}
+
 IN_PROC_BROWSER_TEST_P(FileManagerBrowserDriveTest, TestKeyboardCopy) {
   DoTestKeyboardCopy(&volume_);
 }
 
 IN_PROC_BROWSER_TEST_P(FileManagerBrowserDriveTest, TestKeyboardDelete) {
   DoTestKeyboardDelete(&volume_);
 }
 
 IN_PROC_BROWSER_TEST_P(FileManagerBrowserDriveTest, TestOpenRecent) {
   ResultCatcher catcher;
@@ skipping 69 matching lines @@
 }
 
 IN_PROC_BROWSER_TEST_P(FileManagerBrowserTransferTest,
                        TransferFromOfflineToDrive) {
   ResultCatcher catcher;
   ASSERT_NO_FATAL_FAILURE(StartTest("transferFromOfflineToDrive"));
   ASSERT_TRUE(catcher.GetNextResult()) << catcher.message();
 }
 
 }  // namespace