Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 159839: A quick fix for Issue 18353.... (Closed)

Created:
11 years, 4 months ago by Hironori Bono
Modified:
9 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews_googlegroups.com, darin (slow to review)
Visibility:
Public.

Description

A quick fix for Issue 18353. This is my stupid mistake that I forgot removing the platform-dependent code in our renderer code. This change just add defined(OS_MACOSX) instead of removing #ifdef blocks since they are used by Chrome OS. BUG=18353 "Regression: Arrow Keys and Page Up/Down Keys Have No Affect" TEST=Type an arrow key in a web page and see it scrolls the page. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22601

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M webkit/glue/webview_impl.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Hironori Bono
11 years, 4 months ago (2009-08-04 07:51:12 UTC) #1
Avi (use Gerrit)
I don't like the triple #ifdefs. When you say "used by chrome os", can't you ...
11 years, 4 months ago (2009-08-04 13:46:45 UTC) #2
Avi (use Gerrit)
On 2009/08/04 13:46:45, Avi wrote: > I don't like the triple #ifdefs. When you say ...
11 years, 4 months ago (2009-08-04 14:00:37 UTC) #3
Hironori Bono
Avi, Thank you for your review and comments. I misunderstood about Chrome OS and it ...
11 years, 4 months ago (2009-08-05 10:49:35 UTC) #4
Avi (use Gerrit)
11 years, 4 months ago (2009-08-05 14:05:35 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698