Right clicking the back and forward buttons is buggy. A single right click op...

views/controls/button/custom_button.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "views/controls/button/custom_button.h"
 
 #include "app/throb_animation.h"
 #include "base/keyboard_codes.h"
 
 namespace views {
@@ skipping 79 matching lines @@
   if (enabled_) {
     SetState(BS_NORMAL);
     NotifyClick(0);
     return true;
   }
   return false;
 }
 
 bool CustomButton::OnMousePressed(const MouseEvent& e) {
   if (state_ != BS_DISABLED) {
-    if (IsTriggerableEvent(e) && HitTest(e.location()))
+    if (ShouldEnterPushedState(e) && HitTest(e.location()))
       SetState(BS_PUSHED);
     RequestFocus();
   }
   return true;
 }
 
 bool CustomButton::OnMouseDragged(const MouseEvent& e) {
   if (state_ != BS_DISABLED) {
     if (!HitTest(e.location()))
       SetState(BS_NORMAL);
-    else if (IsTriggerableEvent(e))
+    else if (ShouldEnterPushedState(e))
       SetState(BS_PUSHED);
     else
       SetState(BS_HOT);
   }
   return true;
 }
 
 void CustomButton::OnMouseReleased(const MouseEvent& e, bool canceled) {
   if (InDrag()) {
     // Starting a drag results in a MouseReleased, we need to ignore it.
@@ skipping 85 matching lines @@
     SetState(BS_NORMAL);
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // CustomButton, AnimationDelegate implementation:
 
 void CustomButton::AnimationProgressed(const Animation* animation) {
   SchedulePaint();
 }
 
+bool CustomButton::ShouldEnterPushedState(const MouseEvent& e) {
+  return IsTriggerableEvent(e);
+}
+
 ////////////////////////////////////////////////////////////////////////////////
 // CustomButton, private:
 
 void CustomButton::SetHighlighted(bool highlighted) {
   if (highlighted && state_ != BS_DISABLED) {
     SetState(BS_HOT);
   } else if (!highlighted && state_ != BS_DISABLED) {
     SetState(BS_NORMAL);
   }
 }
 
 bool CustomButton::IsHighlighted() const {
   return state_ == BS_HOT;
 }
 
 bool CustomButton::IsPushed() const {
   return state_ == BS_PUSHED;
 }
 
 }  // namespace views