Issue 15983002: [content shell] When running layout tests on mac, move the window off-screen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15983002: [content shell] When running layout tests on mac, move the window off-screen (Closed)

Created:
7 years, 7 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 7 months ago

Reviewers:
jochen (gone - plz use gerrit), eseidel

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, sail+watch_chromium.org, jochen+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[content shell] When running layout tests on mac, move the window off-screen BUG=111316 R=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202023

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	content/shell/shell_mac.mm	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

eseidel

lgtm Looks like the right mojo: http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm#L553

7 years, 7 months ago (2013-05-24 07:50:06 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/15983002/1

7 years, 7 months ago (2013-05-24 07:50:15 UTC) #3

eseidel

I recommend basically copying exactly what Apple Mac DRT does whenever possible. :) It took ...

7 years, 7 months ago (2013-05-24 07:50:43 UTC) #4

jochen (gone - plz use gerrit)

7 years, 7 months ago (2013-05-24 08:06:59 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r202023 (presubmit successful).