Issue 159828: NNTP: Make the chromium logo smaller so that it has the same height as...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159828: NNTP: Make the chromium logo smaller so that it has the same height as... (Closed)

Created:
11 years, 4 months ago by arv (Not doing code reviews)

Modified:
9 years, 4 months ago

Reviewers:
Glen Murphy

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

NNTP: Make the chromium logo smaller so that it has the same height as the "Google chrome" logo. BUG=17944 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22388

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -0 lines)			Patch
	M	chrome/app/theme/chromium/product_logo.png	View		Binary file		0 comments	Download
	M	chrome/app/theme/chromium/product_logo_white.png	View		Binary file		0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

I skipped the white outline after all. I thought it more important that the end ...

11 years, 4 months ago (2009-08-03 23:34:25 UTC) #1

Glen Murphy

11 years, 4 months ago (2009-08-03 23:36:14 UTC) #2

If they're the same, you could also make the IDR_PRODUCT_LOGO and
IDR_PRODUCT_LOGO_WHITE entries in the GRD just point to the same image.

LGTM either way - leaving it as-is would make adding a white one easier in
future. Up to you.

Expand Messages | Collapse Messages