Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 1598223004: Revert of [mojo] Add CreateSharedBuffer method to Broker. (Closed)

Created:
4 years, 11 months ago by Eliot Courtney
Modified:
4 years, 11 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [mojo] Add CreateSharedBuffer method to Broker. (patchset #12 id:220001 of https://codereview.chromium.org/1555273002/ ) Reason for revert: This breaks some tests on the CFI bot. Reverting until I work out the fix. https://code.google.com/p/chromium/issues/detail?id=578716 Original issue's description: > [mojo] Add CreateSharedBuffer method to Broker. > > BUG=556258 > > Committed: https://crrev.com/565052abf18c8c6cad9a960831fc01f9d6b5b98a > Cr-Commit-Position: refs/heads/master@{#369631} TBR=jam@chromium.org,amistry@chromium.org,sammc@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=556258 Committed: https://crrev.com/2eb0a4f2058b84d8be90fbdd6724250fd43252ef Cr-Commit-Position: refs/heads/master@{#369998}

Patch Set 1 #

Patch Set 2 : presubmits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -283 lines) Patch
M mojo/edk/embedder/platform_channel_utils_posix.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M mojo/edk/embedder/platform_channel_utils_posix.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/edk/system/broker.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M mojo/edk/system/broker_messages.h View 1 1 chunk +9 lines, -15 lines 0 comments Download
M mojo/edk/system/broker_state.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/edk/system/broker_state.cc View 1 2 chunks +0 lines, -7 lines 0 comments Download
M mojo/edk/system/child_broker.h View 1 3 chunks +1 line, -11 lines 0 comments Download
M mojo/edk/system/child_broker.cc View 1 6 chunks +23 lines, -93 lines 0 comments Download
M mojo/edk/system/child_broker_host.h View 1 3 chunks +10 lines, -19 lines 0 comments Download
M mojo/edk/system/child_broker_host.cc View 1 7 chunks +17 lines, -123 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Eliot Courtney
Created Revert of [mojo] Add CreateSharedBuffer method to Broker.
4 years, 11 months ago (2016-01-18 07:25:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1598223004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1598223004/1
4 years, 11 months ago (2016-01-18 07:25:32 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
4 years, 11 months ago (2016-01-18 07:25:33 UTC) #4
dominickn
lgtm
4 years, 11 months ago (2016-01-18 07:39:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1598223004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1598223004/1
4 years, 11 months ago (2016-01-18 07:39:38 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/136481)
4 years, 11 months ago (2016-01-18 07:46:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1598223004/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1598223004/200001
4 years, 11 months ago (2016-01-18 07:52:39 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:200001)
4 years, 11 months ago (2016-01-18 09:28:46 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-18 09:30:08 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2eb0a4f2058b84d8be90fbdd6724250fd43252ef
Cr-Commit-Position: refs/heads/master@{#369998}

Powered by Google App Engine
This is Rietveld 408576698