Issue 159822: linux: fix regression where opening the page menu would cause a reload

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159822: linux: fix regression where opening the page menu would cause a reload (Closed)

Created:
11 years, 4 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

linux: fix regression where opening the page menu would cause a reload I tried to be clever before, but I turned out needing brute force. BUG=17647

Patch Set 1 #

Total comments: 2

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -29 lines)			Patch
	M	chrome/browser/gtk/menu_gtk.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	chrome/browser/gtk/menu_gtk.cc	View		3 chunks	+30 lines, -29 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

LGTM + Think about: http://codereview.chromium.org/159822/diff/1/2 File chrome/browser/gtk/menu_gtk.cc (right): http://codereview.chromium.org/159822/diff/1/2#newcode238 Line 238: return; You may be ...

11 years, 4 months ago (2009-08-03 22:46:34 UTC) #2

Evan Martin

11 years, 4 months ago (2009-08-03 22:58:41 UTC) #3

http://codereview.chromium.org/159822/diff/1/2
File chrome/browser/gtk/menu_gtk.cc (right):

http://codereview.chromium.org/159822/diff/1/2#newcode238
Line 238: return;
On 2009/08/03 22:46:34, Elliot Glaysher wrote:
> You may be able to pull this check out; I think this case is handled with
> |lbock_activate_|.

Nope, you get it when mousing through the menu.  :\

Expand Messages | Collapse Messages