Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1598113003: [runtime] Remove the now unused %StoreArrayLiteralElement. (Closed)

Created:
4 years, 11 months ago by Benedikt Meurer
Modified:
4 years, 11 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Remove the now unused %StoreArrayLiteralElement. The runtime function is no longer used and obsolete by now. R=jarin@chromium.org Committed: https://crrev.com/6faa6b317ab029c8379eda520a3ba6d28bbd5258 Cr-Commit-Position: refs/heads/master@{#33350}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -124 lines) Patch
M src/arm/interface-descriptors-arm.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +0 lines, -8 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +5 lines, -6 lines 0 comments Download
M src/runtime/runtime-literals.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 11 months ago (2016-01-18 06:07:34 UTC) #1
Benedikt Meurer
Hey Jaro, Dead code should be dead. Please take a look. Thanks, Benedikt
4 years, 11 months ago (2016-01-18 06:08:23 UTC) #2
Jarin
lgtm
4 years, 11 months ago (2016-01-18 06:10:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1598113003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1598113003/1
4 years, 11 months ago (2016-01-18 06:11:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-18 06:33:36 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-18 06:34:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6faa6b317ab029c8379eda520a3ba6d28bbd5258
Cr-Commit-Position: refs/heads/master@{#33350}

Powered by Google App Engine
This is Rietveld 408576698