Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 15981005: Normalize image/x-png mime type to the standard one (Closed)

Created:
7 years, 6 months ago by Rafał Chłodnicki
Modified:
7 years, 6 months ago
Reviewers:
flackr, Jói
CC:
grit-developer_googlegroups.com
Visibility:
Public.

Description

Normalize image/x-png mime type to the standard one On Windows, Python's mimetypes.guess_type() would return image/x-png type for PNG files as its default mappings are overriden by a Windows specific mappings read from the registry. Using image/x-png for such resources would trigger a warning when such inlined resource is loaded in the browser (Blink engine at least). Create a helper function that normalizes such known, but unwanted mime types to standard ones. Committed: https://code.google.com/p/grit-i18n/source/detail?r=124

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M grit/format/html_inline.py View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Rafał Chłodnicki
7 years, 6 months ago (2013-06-08 13:45:29 UTC) #1
Jói
7 years, 6 months ago (2013-06-08 14:20:47 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r124 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698