Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 159810: Do proper HSL > HSB conversion.... (Closed)

Created:
11 years, 4 months ago by Avi (use Gerrit)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, John Grabowski, Ben Goodger (Google)
Visibility:
Public.

Description

Do proper HSL > HSB conversion. BUG=http://crbug.com/15760 TEST=slight visual change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22377

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
M chrome/browser/browser_theme_provider_mac.mm View 2 chunks +20 lines, -6 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
Avi (use Gerrit)
11 years, 4 months ago (2009-08-03 20:22:56 UTC) #1
Erik does not do reviews
LGTM http://codereview.chromium.org/159810/diff/1/2 File chrome/browser/browser_theme_provider_mac.mm (right): http://codereview.chromium.org/159810/diff/1/2#newcode15 Line 15: void HSLToHSB(const skia::HSL& hsl, CGFloat* h, CGFloat* ...
11 years, 4 months ago (2009-08-03 22:09:42 UTC) #2
Avi (use Gerrit)
http://codereview.chromium.org/159810/diff/1/2 File chrome/browser/browser_theme_provider_mac.mm (right): http://codereview.chromium.org/159810/diff/1/2#newcode15 Line 15: void HSLToHSB(const skia::HSL& hsl, CGFloat* h, CGFloat* s, ...
11 years, 4 months ago (2009-08-04 13:58:21 UTC) #3
Erik does not do reviews
On Tue, Aug 4, 2009 at 6:58 AM, <avi@chromium.org> wrote: > > http://codereview.chromium.org/159810/diff/1/2 > File ...
11 years, 4 months ago (2009-08-04 14:23:59 UTC) #4
Avi (use Gerrit)
11 years, 4 months ago (2009-08-04 15:51:29 UTC) #5
Apple uses [0, 1) always, since a color for them is just a tuple of [0, 1)
values and the associated namespace to interpret. Like it or not, at least it
makes sense. Why Skia is of two minds about this I can't say.

Powered by Google App Engine
This is Rietveld 408576698