Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 159806: Make NotificationObserver leaks into LOG(INFO). (Closed)

Created:
11 years, 4 months ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Make NotificationObserver leaks into LOG(INFO). This severely cuts down on the WARNING spam seen when running UI tests. Peter already fixed the majority of NotificationObservers into using a scoped class to manage their lifetime, so the remaining observers are unlikely to be changed. BUG=11010

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/common/notification_service.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Martin
11 years, 4 months ago (2009-08-03 20:07:29 UTC) #1
Peter Kasting
11 years, 4 months ago (2009-08-03 20:09:17 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698