Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Issue 159803003: Convert ARM optimizations to GNU syntax (Closed)

Created:
6 years, 10 months ago by tlegrand1
Modified:
6 years, 9 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews
Visibility:
Public.

Description

Convert ARM optimizations to GNU syntax The ARM optimizations included in OPUS 1.1 is written in ARM's RVCT syntax, and we need to convert it to GNU syntax. There's a script for the actual conversion, arm2gnu.pl, added by this CL. The script will be used in opus.gyp to generate files of the format we need. BUG= R=sergeyu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256783

Patch Set 1 #

Total comments: 2

Patch Set 2 : License header and removed files #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+340 lines, -0 lines) Patch
A celt/arm/arm2gnu.pl View 1 1 chunk +340 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
tlegrand1
Hi Sergey, This is a CL I realized needs to be committed before Enabling ARM ...
6 years, 10 months ago (2014-02-11 15:42:17 UTC) #1
Sergey Ulanov
LGTM, but see my comment - arm2gnu.pl needs a license header. https://codereview.chromium.org/159803003/diff/1/celt/arm/arm2gnu.pl File celt/arm/arm2gnu.pl (right): ...
6 years, 10 months ago (2014-02-13 20:27:13 UTC) #2
tlegrand1
On 2014/02/13 20:27:13, Sergey Ulanov wrote: > LGTM, but see my comment - arm2gnu.pl needs ...
6 years, 10 months ago (2014-02-14 13:35:26 UTC) #3
tlegrand1
Hi, I have updated the file to include license header. File is from commit 718b10c6282c3ef9d8052e22aee5e853700c2529 ...
6 years, 9 months ago (2014-03-10 11:40:14 UTC) #4
Sergey Ulanov
lgtm
6 years, 9 months ago (2014-03-11 00:55:39 UTC) #5
tlegrand1
6 years, 9 months ago (2014-03-13 10:08:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r256783 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698