Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 15980011: Replaces 'mobile device' with 'device' for string resources to make sense on other kinds of devices (Closed)

Created:
7 years, 6 months ago by Jinsuk Kim
Modified:
7 years, 6 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Replaces 'mobile device' with 'device' for string resources to make sense on other kinds of devices A couple of exceptions: '... for your computer and mobile devices' -> 'computer and other devices' 'For mobile device' -> 'For Android device' These occur in the field 'desc', so don't affect the translation. They are all about Android device and 'Android device' seems better than just 'For device' to me. BUG=242805 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203937

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address the comment #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -49 lines) Patch
M chrome/app/generated_resources.grd View 33 chunks +52 lines, -49 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Jinsuk Kim
7 years, 6 months ago (2013-06-03 09:38:38 UTC) #1
newt (away)
one change requested, then lgtm https://codereview.chromium.org/15980011/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (left): https://codereview.chromium.org/15980011/diff/1/chrome/app/generated_resources.grd#oldcode6106 chrome/app/generated_resources.grd:6106: - <message name="IDS_POLICY_SCOPE_DEVICE" desc="Mobile: ...
7 years, 6 months ago (2013-06-03 15:20:28 UTC) #2
Jinsuk Kim
Thanks! https://codereview.chromium.org/15980011/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (left): https://codereview.chromium.org/15980011/diff/1/chrome/app/generated_resources.grd#oldcode6106 chrome/app/generated_resources.grd:6106: - <message name="IDS_POLICY_SCOPE_DEVICE" desc="Mobile: Text displayed in the ...
7 years, 6 months ago (2013-06-04 01:16:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinsukkim@chromium.org/15980011/4001
7 years, 6 months ago (2013-06-04 01:27:59 UTC) #4
commit-bot: I haz the power
Failed to apply patch for chrome/app/generated_resources.grd: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 6 months ago (2013-06-04 01:27:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinsukkim@chromium.org/15980011/10001
7 years, 6 months ago (2013-06-04 03:48:31 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-06-04 12:36:47 UTC) #7
Message was sent while issue was closed.
Change committed as 203937

Powered by Google App Engine
This is Rietveld 408576698