Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 15980009: Files.app: Fix errors when launching Files.app via "chrome://files" (Closed)

Created:
7 years, 6 months ago by yoshiki
Modified:
7 years, 6 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Files.app: Fix errors when launching Files.app via "chrome://files" This patch does following when Files.app is launched via "chrome://files". - Not to call chrome.app.window.current().show(). - Disable Close and Maximize button at the top-right. BUG=243414 TEST=Open chrome://files and confirm Files.app shows and the close button and the maximize button doesn't work. R=mtomasz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203795

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M chrome/browser/resources/file_manager/js/file_manager.js View 3 chunks +17 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
yoshiki
@mtomasz: could you take a look?
7 years, 6 months ago (2013-06-03 08:30:50 UTC) #1
mtomasz
On 2013/06/03 08:30:50, yoshiki wrote: > @mtomasz: could you take a look? Can we hide ...
7 years, 6 months ago (2013-06-03 08:33:41 UTC) #2
yoshiki
On 2013/06/03 08:33:41, mtomasz wrote: > On 2013/06/03 08:30:50, yoshiki wrote: > > @mtomasz: could ...
7 years, 6 months ago (2013-06-03 08:40:09 UTC) #3
mtomasz
On 2013/06/03 08:40:09, yoshiki wrote: > On 2013/06/03 08:33:41, mtomasz wrote: > > On 2013/06/03 ...
7 years, 6 months ago (2013-06-03 08:44:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/15980009/1
7 years, 6 months ago (2013-06-03 16:09:52 UTC) #5
yoshiki
Committed patchset #1 manually as r203795 (presubmit successful).
7 years, 6 months ago (2013-06-04 00:01:40 UTC) #6
mtomasz
7 years, 6 months ago (2013-06-04 05:45:02 UTC) #7
Message was sent while issue was closed.
On 2013/06/04 00:01:40, yoshiki wrote:
> Committed patchset #1 manually as r203795 (presubmit successful).

Sorry, I didn't check carefully before, but this change broke Files.app.
chrome.app.window.contentWindow seem to be always undefined.

Powered by Google App Engine
This is Rietveld 408576698