Issue 15980007: Remove unnecessary check from Logger::LogCodeObject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15980007: Remove unnecessary check from Logger::LogCodeObject (Closed)

Created:
7 years, 6 months ago by yurys

Modified:
7 years, 6 months ago

Reviewers:
Sven Panne, loislo, alph, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Remove unnecessary check from Logger::LogCodeObject Logger::LogCodeObjects is the only caller of the method. And all its call sites check for at least one of the coditions before calling LogCodeObjects. So there is no need to check it again. BUG=None R=jkummerow@chromium.org, loislo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14913

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -53 lines)			Patch
	M	src/cpu-profiler.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	src/log.cc	View		1 chunk	+48 lines, -50 lines	0 comments	Download

Total messages: 4 (0 generated)

Jakob Kummerow

LGTM if you're sure this doesn't break command-line usage of d8 with --prof.

7 years, 6 months ago (2013-06-03 09:27:35 UTC) #3

yurys

7 years, 6 months ago (2013-06-03 09:46:40 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r14913 (presubmit successful).